Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError gives mis-leading error message if catching a non-related ValueError #257

Closed
LinuxIsCool opened this issue Feb 21, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@LinuxIsCool
Copy link
Contributor

raise ValueError("\'sim_configs\' N must > 0")

My policy function was raising ValueError due to a mis-use of a numpy function which was raising a ValueError. The "'sim_configs' N must > 0" message was thus very confusing.

Suggestion: cadCAD should define it's own exceptions and raise them explicitly before having a final generic exception for cases like this. Cheers 🌵

@JEJodesty JEJodesty added the invalid This doesn't seem right label Apr 16, 2021
@JEJodesty
Copy link
Member

@LinuxIsCool
Thanks :)
Will move sim_configs exception including this ValueError execution to the correct place

@JEJodesty JEJodesty self-assigned this Apr 16, 2021
@JEJodesty JEJodesty added bug Something isn't working and removed invalid This doesn't seem right labels May 26, 2021
@JEJodesty
Copy link
Member

JEJodesty commented Jun 30, 2021

Updated Build with solution in staging branch
https://github.com/cadCAD-org/cadCAD/tree/staging

@JEJodesty
Copy link
Member

JEJodesty commented Aug 26, 2021

Resolved by ver 0.4.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants