Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: alternative task execution mechanism #341

Closed
os-alan opened this issue Aug 11, 2015 · 2 comments
Closed

Workflows: alternative task execution mechanism #341

os-alan opened this issue Aug 11, 2015 · 2 comments

Comments

@os-alan
Copy link
Contributor

os-alan commented Aug 11, 2015

(this is the continuation of discussion of Workflow from #26)

@patriksvensson

I'm sorry if I sound negative, but it's so easy to add stuff and so difficult to remove them.

That's so true, and you sound pragmatic 😄

I can see a benefit from them if they respect task dependencies and criteria, which would make them a new kind of mechanism for task execution.

I also like the idea of workflows (so much, that I definitely going to implement them as POC at least in my fork 😄 ), but if they would respect Task's dependencies and conditions then there would be almost to difference to Targets (which is currently the only execution model).
The unique feature of the workflows (as I see them) is to allow user to declare dependencies and conditions on level of workflow itself, leaving tasks plain, simple and reusable in other workflows.

This way we could accomplish what you propose simply by not specifying dependencies or criteria for a task.

Looks like this is the way to go.
What if Workflow would work with existing Tasks, but will throw something like InvalidOperationException if it will detect any conditions or dependencies declared on them? This model would let us tick 2 checkboxes:

  • Force user to use Workflow-style execution model (if his intention is to use Workflow)
  • Do not introduce breaking changes to main execution model
  • Do not introduce duplicate code (Jobs etc..)

This way, workflow model will be optional. And it is up to user to decide whether to stick with main model, or alternative.

What you think?

@devlead
Copy link
Member

devlead commented Oct 21, 2016

@os-alan any PoC done you want feedback on? Otherwise I'm going to go ahead and close this issue.

@os-alan
Copy link
Contributor Author

os-alan commented Oct 24, 2016

@devlead No, unfortunately. Agree on closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants