Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decided on Abstract Base class vs Interface #9

Open
ChuckJonas opened this issue Aug 27, 2020 · 1 comment
Open

Decided on Abstract Base class vs Interface #9

ChuckJonas opened this issue Aug 27, 2020 · 1 comment

Comments

@ChuckJonas
Copy link
Contributor

For decoupling the handler, there are two options:

1: Abstract Base Class with TriggerContext as injected variable (current implemenation)
2: Interface with void handle(TriggerContext ctx)

Although it strays from our current approach, I actually the interface has the advantage.

@ChuckJonas
Copy link
Contributor Author

It does complicate backwards compatibility a bit though... We can create a base class that implements the existing Interface and everything just works. Having two competing interfaces is a bit of a mess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant