Autoupdate seems to fail on Windows

[IceNinjaman]

Windows servers seem not to update as they should. Needs to be investigated/fixed before release of new updates.

[IceNinjaman]

This is what I get:

CoD4 X 1.8 win_mingw-x86 build 1999 Mar 28 2017
--- Crypto Initializing ---
Testing sha1 hash function - positive.
Testing sha256 hash function - positive.
Testing tiger hash function - positive.
--- Crypto Initialization Complete ---
----- FS_Startup -----
Warning: WARNING: Invalid IWD localize_d_german_iw07.iwd in \main.
Warning: WARNING: Invalid IWD xbase17_00.iwd in \main.
Current language: german
Current fs_basepath: c:/users/florian/steam/steamapps/common/call of duty 4
Current fs_homepath: c:/users/florian/steam/steamapps/common/call of duty 4
Current search path:
c:\users\florian\steam\steamapps\common\call of duty 4\main\xbase_00.iwd (20 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_13.iwd (265 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_12.iwd (33 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_11.iwd (448 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_10.iwd (230 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_09.iwd (447 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_08.iwd (66 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_07.iwd (34 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_06.iwd (416 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_05.iwd (716 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_04.iwd (765 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_03.iwd (670 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_02.iwd (1296 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_01.iwd (1456 files)
c:\users\florian\steam\steamapps\common\call of duty 4\main\iw_00.iwd (1054 files)
c:/users/florian/steam/steamapps/common/call of duty 4/main
c:/users/florian/steam/steamapps/common/call of duty 4/main_shared
c:/users/florian/steam/steamapps/common/call of duty 4/players
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw06.iwd (512 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw05.iwd (1152 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw04.iwd (1965 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw03.iwd (3496 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw02.iwd (3201 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw01.iwd (3117 files)
    localized assets iwd file for german
c:\users\florian\steam\steamapps\common\call of duty 4\main\localized_german_iw00.iwd (2903 files)
    localized assets iwd file for german

File Handles:
----------------------
24262 files in iwd files
execing default_mp.cfg
execing default_mp_controls.cfg
execing default_mp_gamesettings.cfg
execing server_map.cfg
execing q3config_server.cfg
loc_forceEnglish will be changed upon restarting.
loc_language will be changed upon restarting.
com_zoneMegs will be changed upon restarting.
-------- Plugins initialization completed --------
Winsock Initialized
Hostname: XXXXXXX
IP6: 2003:XXXX:XXXX:a900:XXXX:XXXX:XXXX:XXXX
IP: XXX.80.XXX.11
IP: 127.0.0.1
Opening IP6 socket: [::]:28960 UDP
Opening IP6 socket: [::]:28960 TCP
Opening IP socket: 0.0.0.0:28960 UDP
Opening IP socket: 0.0.0.0:28960 TCP
QUERY LIMIT: Querylimiting is enabled
Resolving cod4master.cod4x.me 
cod4master.cod4x.me resolved to 188.165.57.239:20810
cod4master.cod4x.me resolved to [2001:41d0:a:37ad::17]:20810
[S_API] Initialization completed
loading nvconfig_v3.dat
Loaded nvconfig_v3.dat 0 errors
--- Common Initialization Complete ---
--- Game binary initialization ---

-----------------------------
 CoD4X Auto Update
 Current version: 1.8
 Current subversion: 17
 Current build: 1999
-----------------------------

Downloading file: "cod4x18_dedrun.exe"


Successfully downloaded file "cod4x18_dedrun.exe".
Set permissions for: c:\users\florian\steam\steamapps\common\call of duty 4\cod4x18_dedrun.exe.new
Downloading file: "main/xbase_00.iwd"


Successfully downloaded file "main/xbase_00.iwd".
Downloading file: "steam_api.dll"


Successfully downloaded file "steam_api.dll".
All files downloaded successfully. Applying update...
Removing backup file cod4x18_dedrun.exe.old...
Removing backup file main/xbase_00.iwd.old...
Removing backup file steam_api.dll.old...
Backing up file C:\Users\Florian\Steam\steamapps\common\Call of Duty 4\cod4x18_dedrun.exe...
Backing up file main/xbase_00.iwd...
Error: Couldn't backup file main/xbase_00.iwd
Error: Update has failed. Trying to recover...
Undo backup file cod4x18_dedrun.exe...
Undo backup file main/xbase_00.iwd...
Undo backup file steam_api.dll...
begin $init
end $init 18 ms
Loading fastfile code_post_gfx_mp
Loading fastfile localized_code_post_gfx_mp
Loading fastfile ui_mp
Loading fastfile common_mp
Loading fastfile localized_common_mp
Loaded zone 'code_post_gfx_mp'
Loaded zone 'localized_code_post_gfx_mp'
Loaded zone 'ui_mp'
Loaded zone 'common_mp'
Loaded zone 'localized_common_mp'
--- Game Binary Initialization Complete ---
Hitch warning: 26675 msec frame time

[T-Maxxx]

main/xbase_00.iwd is in use. So auto-updater fails to rename it (it's copied anyway but original still exists).
Here: https://github.com/callofduty4x/CoD4x_Server/blob/master/src/sec_update.c#L376 second check if file exists. And because there we have .iwd, .iwd.new and .iwd.old - call returns true and here https://github.com/callofduty4x/CoD4x_Server/blob/master/src/sec_update.c#L384 it throws error.

I assume, you have added this file to searchpath to be able to load plugins from it?

[AlexanderCurl]

My windows server updated fine with autoupdater.

[wkuzma]

I run my server on Windows 7 enterprise 64 bit system
When the server did update I found that xbase_00.iwd was never deleted but there was also
xbase_00.iwd.new and xbase_00.iwd.old in the main directory.
also after the downloading of cod4x18_dedrun.exe and restaring the server I found that there was no
cod4x18_dedrun.exe in the directory however there was a cod4x18_dedrun.exe.new and a cod4x18_dedrun.exe.old in the directory I renamed the cod4x18_dedrun.exe.new to cod4x18_dedrun.exe
and then had no problem I also did the same renaming on xbase_oo,iwd.new after removing the xbase_00.iwd
I posted ths for information on the update.

[IceNinjaman]

Should work in 17.5 now under the condition fs_homepath is unique to each cod4 server running.