From a98936a560a81e9b347a0e401e8c3c73725d6346 Mon Sep 17 00:00:00 2001 From: Corey Oordt Date: Mon, 7 Aug 2023 08:50:58 -0500 Subject: [PATCH] Created failing test for version message !minor --- tests/fixtures/csharp/.bumpversion.toml | 41 ++++++++++ tests/fixtures/csharp/AssemblyInfo.cs | 2 + tests/fixtures/csharp/FULL_VERSION.txt | 1 + tests/fixtures/csharp/Version.csv | 1 + tests/test_files.py | 101 +++++++++--------------- 5 files changed, 84 insertions(+), 62 deletions(-) create mode 100644 tests/fixtures/csharp/.bumpversion.toml create mode 100644 tests/fixtures/csharp/AssemblyInfo.cs create mode 100644 tests/fixtures/csharp/FULL_VERSION.txt create mode 100644 tests/fixtures/csharp/Version.csv diff --git a/tests/fixtures/csharp/.bumpversion.toml b/tests/fixtures/csharp/.bumpversion.toml new file mode 100644 index 00000000..ae756f1a --- /dev/null +++ b/tests/fixtures/csharp/.bumpversion.toml @@ -0,0 +1,41 @@ +[tool.bumpversion] +current_version = "3.1.0-rc+build.1031" +parse = "(?P\\d+)\\.(?P\\d+)\\.(?P\\d+)(-(?P[0-9A-Za-z]+))?(\\+build\\.(?P.[0-9A-Za-z]+))?" +serialize = ["{major}.{minor}.{patch}-{release}+build.{build}", "{major}.{minor}.{patch}+build.{build}"] +commit = true +message = "Bump version: {current_version} -> {new_version}" +tag = false +tag_name = "{new_version}" +tag_message = "Version {new_version}" +allow_dirty = true + +[[tool.bumpversion.files]] +filename = "FULL_VERSION.txt" + +[[tool.bumpversion.files]] +filename = "AssemblyInfo.cs" +search = "[assembly: AssemblyFileVersion(\"{current_version}\")]" +replace = "[assembly: AssemblyFileVersion(\"{new_version}\")]" + +[[tool.bumpversion.files]] +filename = "AssemblyInfo.cs" +parse = "(?P\\d+)\\.(?P\\d+)\\.(?P\\d+)\\.(?P\\d+)" +serialize = ["{major}.{minor}.{build}.{patch}"] +search = "[assembly: AssemblyVersion(\"{current_version}\")]" +replace = "[assembly: AssemblyVersion(\"{new_version}\")]" + +[[tool.bumpversion.files]] +filename = "Version.csv" +parse = "(?P\\d+);(?P\\d+);(?P\\d+);(?P[0-9A-Za-z]+)?;(build\\.(?P.[0-9A-Za-z]+))?" +serialize = ["{major};{minor};{patch};{release};build.{build}", "{major};{minor};{patch};;build.{build}"] +search = "1;{current_version}" +replace = "1;{new_version}" + +[tool.bumpversion.parts] +[tool.bumpversion.parts.release] +values = ["beta", "rc", "final"] +optional_value = "final" + +[tool.bumpversion.parts.build] +first_value = 1000 +independent = true diff --git a/tests/fixtures/csharp/AssemblyInfo.cs b/tests/fixtures/csharp/AssemblyInfo.cs new file mode 100644 index 00000000..c741b7e7 --- /dev/null +++ b/tests/fixtures/csharp/AssemblyInfo.cs @@ -0,0 +1,2 @@ +[assembly: AssemblyFileVersion("3.1.0-rc+build.1031")] +[assembly: AssemblyVersion("3.1.1031.0")] diff --git a/tests/fixtures/csharp/FULL_VERSION.txt b/tests/fixtures/csharp/FULL_VERSION.txt new file mode 100644 index 00000000..f199917c --- /dev/null +++ b/tests/fixtures/csharp/FULL_VERSION.txt @@ -0,0 +1 @@ +3.1.0-rc+build.1031 diff --git a/tests/fixtures/csharp/Version.csv b/tests/fixtures/csharp/Version.csv new file mode 100644 index 00000000..defac4ee --- /dev/null +++ b/tests/fixtures/csharp/Version.csv @@ -0,0 +1 @@ +1;3;1;0;rc;build.1031 diff --git a/tests/test_files.py b/tests/test_files.py index 7fb45842..dfd2caed 100644 --- a/tests/test_files.py +++ b/tests/test_files.py @@ -1,5 +1,6 @@ """File processing tests.""" import os +import shutil from datetime import datetime, timezone from pathlib import Path from textwrap import dedent @@ -7,9 +8,10 @@ import pytest from pytest import param -from bumpversion import exceptions, files +from bumpversion import exceptions, files, config, bump from bumpversion.utils import get_context from bumpversion.exceptions import VersionNotFoundError +from bumpversion.version_part import VersionConfig from tests.conftest import get_config_data, inside_dir @@ -154,71 +156,46 @@ def test_multi_file_configuration(tmp_path: Path): assert build_num_path.read_text() == "2.0.1+jane+38945" -def test_raises_correct_missing_version_string(tmp_path: Path): - full_vers_path = tmp_path / "FULL_VERSION.txt" - full_vers_path.write_text("3.1.0-rc+build.1031") - assembly_path = tmp_path / "AssemblyInfo.cs" - assembly_path.write_text( - '[assembly: AssemblyFileVersion("3.1.0-rc+build.1031")]\n' '[assembly: AssemblyVersion("3.1.1031.0")]' - ) - csv_path = tmp_path / "Version.csv" - csv_path.write_text("1;3-1;0;rc;build.1031") +def test_raises_correct_missing_version_string(tmp_path: Path, fixtures_path: Path): + """When a file is missing the version string, the error should indicate the correct serialization missing.""" + csharp_path = fixtures_path / "csharp" + dst_path: Path = shutil.copytree(csharp_path, tmp_path / "csharp") - overrides = { - "current_version": "3.1.0-rc+build.1031", - "parse": r"(?P\d+)\.(?P\d+)\.(?P\d+)(-(?P[0-9A-Za-z]+))?(\+build\.(?P.[0-9A-Za-z]+))?", - "serialize": ["{major}.{minor}.{patch}-{release}+build.{build}", "{major}.{minor}.{patch}+build.{build}"], - "commit": True, - "message": "Bump version: {current_version} -> {new_version}", - "tag": False, - "tag_name": "{new_version}", - "tag_message": "Version {new_version}", - "allow_dirty": True, - "files": [ - { - "filename": str(full_vers_path), - }, - { - "filename": str(assembly_path), - "search": '[assembly: AssemblyFileVersion("{current_version}")]', - "replace": '[assembly: AssemblyFileVersion("{new_version}")]', - }, - { - "filename": str(assembly_path), - "parse": r"(?P\d+)\.(?P\d+)\.(?P\d+)\.(?P\d+)", - "serialize": ["{major}.{minor}.{build}.{patch}"], - "search": '[assembly: AssemblyVersion("{current_version}")]', - "replace": '[assembly: AssemblyVersion("{new_version}")]', - }, - { - "filename": str(csv_path), - "parse": r"(?P\d+);(?P\d+);(?P\d+);(?P[0-9A-Za-z]+)?;(build\.(?P.[0-9A-Za-z]+))?", - "serialize": [ - "{major};{minor};{patch};{release};build.{build}", - "{major};{minor};{patch};;build.{build}", - ], - "search": "1;{current_version}", - "replace": "1;{new_version}", - }, - ], - "parts": { - "release": {"values": ["beta", "rc", "final"], "optional_value": "final"}, - "build": { - "first_value": 1000, - "independent": True, - }, - }, - } - conf, version_config, current_version = get_config_data(overrides) - major_version = current_version.bump("patch", version_config.order) + with inside_dir(dst_path): + conf = config.get_configuration(config_file=dst_path.joinpath(".bumpversion.toml")) + version_config = VersionConfig(conf.parse, conf.serialize, conf.search, conf.replace, conf.parts) + current_version = version_config.parse(conf.current_version) + dst_path.joinpath("Version.csv").write_text("1;3-1;0;rc;build.1031") - ctx = get_context(conf) + major_version = current_version.bump("patch", version_config.order) + ctx = get_context(conf) + + configured_files = [files.ConfiguredFile(file_cfg, version_config) for file_cfg in conf.files] + + with pytest.raises(VersionNotFoundError) as e: + files.modify_files(configured_files, current_version, major_version, ctx) + assert e.message.startswith("Did not find '1;3;1;0;rc;build.1031'") + + +def test_uses_correct_serialization_for_tag_and_commit_messages(git_repo: Path, fixtures_path: Path, caplog): + """The tag and commit messages should use the root configured serialization.""" + import subprocess + import logging + + caplog.set_level(logging.INFO) + + csharp_path = fixtures_path / "csharp" + dst_path: Path = shutil.copytree(csharp_path, git_repo / "csharp") + subprocess.check_call(["git", "add", "."], cwd=git_repo) + subprocess.check_call(["git", "commit", "-m", "Initial commit"], cwd=git_repo) + subprocess.check_call(["git", "tag", "3.1.0-rc+build.1031"], cwd=git_repo) - configured_files = [files.ConfiguredFile(file_cfg, version_config) for file_cfg in conf.files] + with inside_dir(dst_path): + config_file = dst_path.joinpath(".bumpversion.toml") + conf = config.get_configuration(config_file=config_file) + bump.do_bump("patch", None, conf, config_file, dry_run=True) - with pytest.raises(VersionNotFoundError) as e: - files.modify_files(configured_files, current_version, major_version, ctx) - assert e.message.startswith("Did not find '1;3;1;0;rc;build.1031'") + assert "Bump version: 3.1.0-rc+build.1031 -> 3.1.1" in caplog.text def test_search_replace_to_avoid_updating_unconcerned_lines(tmp_path: Path, caplog):