Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: transform spread operator for Hermes #670

Merged
merged 1 commit into from
Oct 30, 2019
Merged

fix: transform spread operator for Hermes #670

merged 1 commit into from
Oct 30, 2019

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Oct 30, 2019

Summary

Hermes doesn't support spread operator. Added the necessary plugins to transform them to ES5 syntax.

Test plan

All tests should pass.

@tido64
Copy link
Contributor Author

tido64 commented Oct 30, 2019

cc @zamotany, @thymikee

@zamotany zamotany merged commit 1227e01 into callstack:master Oct 30, 2019
@tido64 tido64 deleted the tido/hermes-spread-ops branch October 30, 2019 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zamotany zamotany zamotany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @zamotany