From d6676dde43155482b7625b3ecfe41bf3a79cfcd6 Mon Sep 17 00:00:00 2001 From: Maciej Jastrzebski Date: Sun, 16 Jun 2024 18:25:27 +0200 Subject: [PATCH] refactor: tweaks output --- packages/compare/src/output/markdown.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/compare/src/output/markdown.ts b/packages/compare/src/output/markdown.ts index 81872688..8b85e1cf 100644 --- a/packages/compare/src/output/markdown.ts +++ b/packages/compare/src/output/markdown.ts @@ -208,25 +208,25 @@ function buildRenderIssuesList(issues: RenderIssues | undefined) { const output = ['Render issues:']; if (issues?.initialUpdateCount) { - output.push(` - Initial updates: ${formatInitialUpdates(issues.initialUpdateCount)}`); + output.push(` - Initial updates: ${formatInitialUpdates(issues.initialUpdateCount, false)}`); } - if (issues?.redundantUpdates) { - output.push(` - Redundant updates: ${formatRedundantUpdates(issues.redundantUpdates)}`); + if (issues?.redundantUpdates?.length) { + output.push(` - Redundant updates: ${formatRedundantUpdates(issues.redundantUpdates, false)}`); } return output.join('
'); } -function formatInitialUpdates(count: number | undefined) { +function formatInitialUpdates(count: number | undefined, showSymbol: boolean = true) { if (count == null) return '?'; if (count === 0) return '-'; - return `${count} 🔴`; + return `${count}${showSymbol ? ' 🔴' : ''}`; } -function formatRedundantUpdates(redundantUpdates: number[] | undefined) { +function formatRedundantUpdates(redundantUpdates: number[] | undefined, showSymbol: boolean = true) { if (redundantUpdates == null) return '?'; if (redundantUpdates.length === 0) return '-'; - return `${redundantUpdates.length} (${redundantUpdates.join(', ')}) 🔴`; + return `${redundantUpdates.length} (${redundantUpdates.join(', ')})${showSymbol ? ' 🔴' : ''}`; }