-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement use of linting rule set for Carrier Billing API #126
Comments
Linter rules output: https://github.com/PedroDiez/CarrierBillingCheckOut/actions/runs/7642915617/job/20823677108?pr=1 Main topics are API spec errors needed to be fixed. Take advantage of #134 to deal with them |
Re-open explicitly issue, as want to check intermediate outputs |
Considerations/Feedback:
|
Please @rartych when you can, in order on how to proceed with topics: i, iv, v and vi |
Linter according to 31/JAN config applied: Pending to check output: https://github.com/PedroDiez/CarrierBillingCheckOut/actions/runs/7759600592/job/21163998825?pr=1 |
Update the files from the PR. and test them. Test today 07/FEB |
Tested linter again:
code/API_definitions/carrier_billing.yaml |
` /github/workspace/documentation/SupportingDocuments/carrier_billing_payment.yaml ` |
The second one is due to Linter is checking all yaml files within the repo so i will adapt linter to only check the one in the code sub-folder repository That means @rartych that linter rules work OK within Carrier Billing |
@rartych checked again with the latest linter configuration in Commonalities and it is OK!!!! https://github.com/PedroDiez/CarrierBillingCheckOut/actions/runs/7829282529/job/21360950171?pr=1 ❌ Linted [YAML] files with [yamllint]: Found 1 error(s) - (0.52s) (expand for details)
Just format topics, for them I will trigger PR cc @bigludo7 |
After latest linter test, all is working successfully: PedroDiez#1 So that configuration is working for Carrier Billing |
Problem description
Implement use of linting rule set for Carrier Billing API.
what we have to do is well documented in Commonalities:
camaraproject/Commonalities#110
camaraproject/Commonalities#74
Expected action
Check our API with linting rule set
provide feedback to commonalities team
Additional context
cc: @rartych who asked project volunteer to perform this action.
The text was updated successfully, but these errors were encountered: