Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): fix CSS to highlight sequence flows #143

Merged
merged 1 commit into from
May 10, 2020
Merged

fix(app): fix CSS to highlight sequence flows #143

merged 1 commit into from
May 10, 2020

Conversation

saig0
Copy link
Contributor

@saig0 saig0 commented May 9, 2020

  • dump bpmn-js version to 6.5.1

@saig0
fix(app): fix CSS to highlight sequence flows
35dfb7a 
* dump bpmn-js version to 6.5.1
@saig0 saig0 merged commit 91a4a77 into master May 10, 2020
@saig0 saig0 deleted the 142-highlight-sequence-flows branch May 10, 2020 09:54
@saig0 saig0 mentioned this pull request May 10, 2020
Closed
@ahumellihuk
Copy link

ahumellihuk commented May 20, 2020 •
edited
Loading

But if you remove bpmn-js webjar, where do you get the CSS resources for header.html?

@saig0
Copy link
Contributor Author

saig0 commented May 22, 2020

I removed the webjar dep because the dependency to bpmn-js was outdated. So, I integrated the JS lib directly.

@ahumellihuk
Copy link

Sorry for delay. What I meant to say was header.html still refers to the removed webjar for CSS resources:

    <!-- bpmn-js viewer -->
    <link type="text/css" rel="stylesheet" href="/webjars/bpmn-js/dist/assets/diagram-js.css"/>
    <link type="text/css" rel="stylesheet" href="/webjars/bpmn-js/dist/assets/bpmn-font/css/bpmn-embedded.css"/>

@saig0
Copy link
Contributor Author

saig0 commented Jun 2, 2020

Ah, true. Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saig0 @ahumellihuk