Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add socket send and receive buffers size details to broker and gateway #4695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add socket send and receive buffers size details to broker and gateway #4695

wants to merge 1 commit into from
+14 −6

Conversation

filipecampos
Copy link

@filipecampos filipecampos commented Dec 3, 2024 •
edited
Loading

Description

Adding information on the new socketReceiveBuffer and socketSendBuffer network configuration parameters for the broker and the gateway that were introduced in camunda/camunda#24104. introduced new configuration parameters to define the size of socket send and receive buffers in brokers and gateways.

This information was added to the corresponding configurations documentation.

Broker - zeebe.broker.network

Gateway - zeebe.gateway.network

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

👋 🤖 🤔 Hello, @filipecampos! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/self-managed/zeebe-deployment/configuration/broker.md
  • docs/self-managed/zeebe-deployment/configuration/gateway.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@filipecampos filipecampos linked an issue Dec 3, 2024 that may be closed by this pull request
docs: add socket send and receive buffers size parameters details #4694
Open
@filipecampos filipecampos requested a review from npepinpe December 3, 2024 11:22
@filipecampos filipecampos added component:zeebe Issues related with Zeebe project target:8.7 Issues included in the 8.7 release labels Dec 3, 2024
npepinpe
npepinpe previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Please address all comments, mostly that you left the default value as 4MB everywhere (I assume due to copy pasting). But no need for another review.

docs/self-managed/zeebe-deployment/configuration/broker.md Outdated Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/broker.md Outdated Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/broker.md Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/broker.md Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/gateway.md Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/gateway.md Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/gateway.md Outdated Show resolved Hide resolved
docs/self-managed/zeebe-deployment/configuration/gateway.md Outdated Show resolved Hide resolved
@filipecampos filipecampos added the 8.7.0-alpha3 January 2024 alpha release label Dec 3, 2024
@filipecampos filipecampos force-pushed the 4694-add-socket-send-and-receive-buffers-size-parameters-details branch from 804ccfc to 996832f Compare December 3, 2024 12:11
@filipecampos filipecampos marked this pull request as ready for review December 3, 2024 12:12
@filipecampos filipecampos requested a review from npepinpe December 3, 2024 15:10
@filipecampos filipecampos force-pushed the 4694-add-socket-send-and-receive-buffers-size-parameters-details branch from 996832f to e5ab8b1 Compare December 3, 2024 16:29
@akeller akeller requested a review from a team December 3, 2024 21:54
@akeller
Copy link
Member

akeller commented Dec 3, 2024

👋 If this is for alpha3, you may want to put a hold label on this so it doesn't get accidentally merged ahead of alpha2!

@npepinpe npepinpe added the hold This issue is parked, do not merge. label Dec 4, 2024
mesellings
mesellings approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - approved! 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesellings mesellings mesellings approved these changes

@npepinpe npepinpe npepinpe approved these changes

Assignees

@filipecampos filipecampos

Labels
8.7.0-alpha3 January 2024 alpha release component:zeebe Issues related with Zeebe project hold This issue is parked, do not merge. target:8.7 Issues included in the 8.7 release
Projects
Developer Experience
Status: 👀 In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: add socket send and receive buffers size parameters details
4 participants
@filipecampos @akeller @npepinpe @mesellings