Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot easily drill down the collapsed subprocess as append element gets focussed #4548

Open
GeethaParthasarathy opened this issue Sep 24, 2024 · 7 comments
Assignees
Labels
bug Something isn't working modeling ready Ready to be worked on ux

Comments

@GeethaParthasarathy
Copy link

GeethaParthasarathy commented Sep 24, 2024

Describe the bug

When we have a collapsed subprocess with the new context pad hovering on the drill down arrow also focusses on the append element making it difficult click on the drill down arrow

Steps to reproduce

  1. Create a collapsed subprocess
  2. Try to click on the drill down arrow
Screen.Recording.2024-09-24.at.14.09.41.mov

Expected behavior

Focus on the drill down arrow and make it possible to click

Environment

  • OS: [MacOS 10.2]
  • Camunda Modeler Version: [5.28.0]
  • Execution Platform: [Camunda 8]
  • Installed plug-ins: [...]

Additional context

No response

@GeethaParthasarathy GeethaParthasarathy added the bug Something isn't working label Sep 24, 2024
@nikku nikku added ready Ready to be worked on modeling ux labels Sep 25, 2024
@nikku
Copy link
Member

nikku commented Sep 25, 2024

@philippfromme @lmbateman I'd be interested to understand your assessment of this UX challenge. From what the looks of it drilldown is not easily possible using the improved canvas.

@lmbateman
Copy link

lmbateman commented Sep 25, 2024

I thought from Geetha's example that there might be some steps we could take to fix it, like separating the icons a bit more and perhaps decreasing the click target for the append menu, but now I think it will require a bit more than that:
image

For the context pad issue, I wonder if it makes sense to move the start element down just enough that the context pad can appear above tasks by default. Or actually, I've just noticed that when you append a task, it gets nudged down automatically, so perhaps we can do that with sub-processes as well.

image

This brings us back to the original problem. I'm not sure why my expand button is in a different spot than Geetha's (directly under vs. off to the right); could that be due to screen size? I think understanding how the positioning works might be helpful in thinking about a solution.

@nikku
Copy link
Member

nikku commented Sep 25, 2024

@philippfromme Maybe you can work together with @lmbateman here?

@philippfromme
Copy link
Contributor

philippfromme commented Oct 22, 2024

I thought about moving it so it's inside the element similar to DMN decision table and literal expression icons:

brave_6Cio3DVeTQ

However, if there's a boundary event it's not ideal:

brave_LjcTZyeSdL

I also tried moving the overlay slightly will still conflict with the context pad when zoomed in since the overlay scales and the context pad doesn't.

brave_wbk334Xf2D

Not scaling it will make it look detached when zoomed in. To fix this we'd need to make the overlay a non-overlay like the context pad is now or change the overlays feature.

brave_U5AGBQTrts

If we change the overlay to behave like the context pad and the append icons it would look like this when zoomed in:

image

This would be my preferred solution but would mean a little more work.

Moving the button to the context pad doesn't make sense because the viewer doesn't have a context pad.

@philippfromme
Copy link
Contributor

philippfromme commented Oct 22, 2024

@lmbateman Wondering if any of the options you'd approve?

@lmbateman
Copy link

I like the idea of moving it into the element, but two thoughts:

  • It seems like the collapsed subprocess is mutually exclusive with other task types. In that case, I wonder about putting the icon in the upper left, like the other task type icons. One downside is that this would be the only interactive icon in that position in the BPMN editor, but there is a precedent in the DMN editor.
  • There are a lot of blue and white plus signs floating around. Is the plus-sign-inside-a-square part of the BPMN standard? If so, I would keep the separate blue and white arrow and go with the option of moving the overlay slightly (the option that requires more work, sadly).

@philippfromme
Copy link
Contributor

I agree that moving the icon to the upper left corner would be cofusing.

The BPMN spec states:

The Sub-Process marker MUST be a small square with a plus sign (+) inside. The square MUST be
positioned at the bottom center of the shape.

So we cannot change that.

So it seems like we'll keep the general position bottom right of the element but adjust it slightly and make sure it behaves like the context pad in terms of position and scaling when zooming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working modeling ready Ready to be worked on ux
Projects
None yet
Development

No branches or pull requests

4 participants