Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm integration tests for release branches #2612

Merged
merged 12 commits into from
May 27, 2024
Merged

Helm integration tests for release branches #2612

merged 12 commits into from
May 27, 2024

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented May 22, 2024 •
edited
Loading

Description

Follow up on #2530.

Previously, INTEGRATION_TEST.md would always pass in the default values. This works well for SNAPSHOT's.

However, for patches on minor versions (especially 8.3), the Helm integration tests need to be passed in dependencies that correspond to the that minor version.

This PR will:

  • determine the correct connectors version to use based on the maven project version (if not provided)
  • determine the correct Helm chart to use (i.e. Helm chart repository git ref)
  • call the integration-test-template.yml with these inputs

ℹ️ Compared to the PR from @ev-codes (#2530), this approach should be simpler because it assumes that we don't need to provide the whole values file in extraValues when calling a custom Helm charts branch.

Related issues

closes https://github.com/camunda/team-connectors/issues/764

@chillleader chillleader self-assigned this May 22, 2024
@chillleader chillleader marked this pull request as ready for review May 22, 2024 15:11
@chillleader chillleader requested a review from a team as a code owner May 22, 2024 15:11
@chillleader chillleader requested a review from ev-codes May 22, 2024 15:11
@chillleader chillleader changed the title Helm integration tests release branches Helm integration tests for release branches May 22, 2024
igpetrov
igpetrov previously approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chillleader @igpetrov
Apply branding :)
7e5315a 
Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
@chillleader
Copy link
Member Author

I'm moving this back to draft state because the Helm integration test GHA will undergo major refactoring and the inputs will change next week. 🔒 Source

@chillleader chillleader marked this pull request as draft May 23, 2024 14:46
@ev-codes ev-codes mentioned this pull request May 27, 2024
Closed
@chillleader chillleader marked this pull request as ready for review May 27, 2024 11:36
@chillleader
Copy link
Member Author

We're merging this now to benefit from this solution already while the workflow refactoring on the Distro side is still in progress

@chillleader chillleader added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 3cf7393 May 27, 2024
16 checks passed
@chillleader chillleader deleted the helm-integration-tests-release-branches branch May 27, 2024 11:49
@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release/8.3, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.3
git worktree add -d .worktree/backport-2612-to-release/8.3 origin/release/8.3
cd .worktree/backport-2612-to-release/8.3
git switch --create backport-2612-to-release/8.3
git cherry-pick -x 3cf73934df091d2b3c83f4f7c2736769b89e9d85

@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release/8.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.4
git worktree add -d .worktree/backport-2612-to-release/8.4 origin/release/8.4
cd .worktree/backport-2612-to-release/8.4
git switch --create backport-2612-to-release/8.4
git cherry-pick -x 3cf73934df091d2b3c83f4f7c2736769b89e9d85

@github-actions GitHub Actions
Copy link
Contributor

Backport failed for release/8.5, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/8.5
git worktree add -d .worktree/backport-2612-to-release/8.5 origin/release/8.5
cd .worktree/backport-2612-to-release/8.5
git switch --create backport-2612-to-release/8.5
git cherry-pick -x 3cf73934df091d2b3c83f4f7c2736769b89e9d85

@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release/8.6:

github-actions bot pushed a commit that referenced this pull request May 27, 2024
@chillleader @github-actions
Helm integration tests for release branches (#2612)
f7695f1 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
@github-actions github-actions bot mentioned this pull request May 27, 2024
Merged
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
20007ae 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
8f0cbf4 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
6b80d01 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
70a1f0c 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
This was referenced May 27, 2024
Merged
Merged
Merged
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
795f876 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
b4f60f7 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
chillleader added a commit that referenced this pull request May 27, 2024
@chillleader
Helm integration tests for release branches (#2612)
7a6bdcc 
* ci: test patches for older minor versions with correct dependencies

* fix workflow

* add prepare java

* add result logging

* add result logging

* setup java

* use newer syntax to set outputs

* try running mvn in offline mode for faster execution

* fix id

* simplify mvn version check

* fix connectors version

* Apply branding :)

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>

---------

Co-authored-by: Igor Petrov <108870003+igpetrov@users.noreply.github.com>
(cherry picked from commit 3cf7393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igpetrov igpetrov igpetrov approved these changes

@ev-codes ev-codes Awaiting requested review from ev-codes

Assignees

@chillleader chillleader

Labels
backport release/8.3 backport release/8.4 backport release/8.5 backport release/8.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chillleader @igpetrov