refactor(document-handling): Hacking session split document modules #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erializer module and serializer module
mathias-vandaele
changed the title
johnBgood
previously approved these changes
Dec 19, 2024
| @@ -59,7 +59,8 @@ public FeelEngineWrapper() { | |||
| .registerModule(DefaultScalaModule$.MODULE$) | |||
| .registerModule(new JavaTimeModule()) | |||
| .registerModule(new Jdk8Module()) | |||
| .registerModule(new JacksonModuleDocument(new DocumentFactoryImpl(null), null)) | |||
| .registerModule( | |||
| new JacksonModuleDocumentDeserializer(new DocumentFactoryImpl(null), null)) | |||
There was a problem hiding this comment.
we might need the serializer only righ?
|
|
||
| @Override | ||
| public String getModuleName() { | ||
| return "JacksonModuleDocument"; |
There was a problem hiding this comment.
we need to update the name, same for the other module
| @Override | ||
| public Version version() { | ||
| // TODO: get version from pom.xml | ||
| return new Version(0, 1, 0, null, "io.camunda", "jackson-datatype-document"); |
|
Looks good, can you exclude all files not relevant to the document module changes? |
Hey @sbuettner, it was said during the hacking session that we could be doing both same times, but you are right, to be cleaner, let's separate both PR |
…erializer module and serializer module 2
mathias-vandaele
force-pushed
the
hacking-session-split-document-modules
branch
from
02666be to
401df28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hacking session on document handling
Related issues
closes #
Checklist
no milestonelabel.