Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-runtime): add exclusion of spring-core creating dependencies incompatibility #3822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathias-vandaele
Copy link
Contributor

Description

Done during hacking session to make developper experience better while creating new connectors

Related issues

closes #

Checklist

  • PR has a milestone or the no milestone label.

@mathias-vandaele mathias-vandaele self-assigned this Dec 19, 2024
@mathias-vandaele mathias-vandaele added this to the 8.7.0-alpha3 milestone Dec 19, 2024
@sbuettner
Copy link
Contributor

@mathias-vandaele Great that you found something that improves the devx. Could you provide some information why it was done to get a better understanding?

@mathias-vandaele
Copy link
Contributor Author

mathias-vandaele commented Dec 20, 2024

@mathias-vandaele Great that you found something that improves the devx. Could you provide some information why it was done to get a better understanding?

@sbuettner

I am trying to provide a good experience for the dev, with the outbound template. there were an incompatibility within the camunda-sdk between spring-web and spring-core, the reason why it works in our repo is unknown as it seems that it brings spring-core 6.2 but when importing it from the template it brings spring-boot 6.1.14.

We decided to exclude it from the camunda-spring-sdk so now the pom on the template side is very clean and does not requires any tricks to work

The PR is here btw camunda/connector-template-outbound#149

@sbuettner
Copy link
Contributor

Thanks, please check via dependency:tree where and how the dependencies are coming from as excluding might also lead to surprises in the future. If there are issues we might need to raise them with the camunda sdk team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants