Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
12750: deps(maven): bump testcontainers-bom from 1.18.0 to 1.18.1 r=github-actions[bot] a=dependabot[bot]

Bumps [testcontainers-bom](https://github.com/testcontainers/testcontainers-java) from 1.18.0 to 1.18.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/testcontainers/testcontainers-java/releases">testcontainers-bom's releases</a>.</em></p>
<blockquote>
<h2>1.18.1</h2>
<h1>What's Changed</h1>
<ul>
<li>Favor copy compose file instead of mount (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6945">#6945</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
<li>Allow <code>`@Container</code>` to be used as a meta-annotation (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6914">#6914</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
</ul>
<h2>🚀 Features &amp; Enhancements</h2>
<ul>
<li>Support Kraft post Confluent Platform 7.4.0 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7014">#7014</a>) <a href="https://github.com/danielpetisme"><code>`@​danielpetisme</code></a></li>`
<li>Alternative waiting strategy for Mockserver container (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6951">#6951</a>) <a href="https://github.com/DenilssonMontoya"><code>`@​DenilssonMontoya</code></a></li>`
<li>Update RedpandaContainer.java (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6939">#6939</a>) <a href="https://github.com/shelajev"><code>`@​shelajev</code></a></li>`
</ul>
<h2>🐛 Bug Fixes</h2>
<ul>
<li>Lowercase identifier in DockerComposeContainer (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6944">#6944</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
<li>Use the current thread's classloader for classes (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6926">#6926</a>) <a href="https://github.com/snowe2010"><code>`@​snowe2010</code></a></li>`
</ul>
<h2>📖 Documentation</h2>
<ul>
<li>Add new section for test integrations (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6930">#6930</a>) <a href="https://github.com/LeoColman"><code>`@​LeoColman</code></a></li>`
</ul>
<h2>🧹 Housekeeping</h2>
<ul>
<li>Test against Cassandra 4.x (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7013">#7013</a>) <a href="https://github.com/wakingrufus"><code>`@​wakingrufus</code></a></li>`
<li>Update lombok version to 1.18.26 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6935">#6935</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
<li>Fix generated pom with duplicated entries (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6931">#6931</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
</ul>
<h2>📦 Dependency updates</h2>
<ul>
<li>Bump Pulsar version to 3.0.0 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7016">#7016</a>) <a href="https://github.com/nicoloboschi"><code>`@​nicoloboschi</code></a></li>`
<li>Update Gradle Wrapper to 8.1.1 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6933">#6933</a>) <a href="https://github.com/github-actions"><code>`@​github-actions</code></a></li>`
<li>Combined dependencies PR (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6912">#6912</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
<li>Combined dependencies PR (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6908">#6908</a>) <a href="https://github.com/eddumelendez"><code>`@​eddumelendez</code></a></li>`
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/c64aab9fd5e3a452ee0faf793560327eb4da9841"><code>c64aab9</code></a> Support Kraft post Confluent Platform 7.4.0 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7014">#7014</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/3616ebf95319ec421ce6290f3c84785848d128eb"><code>3616ebf</code></a> Bump Pulsar version to 3.0.0 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7016">#7016</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/6ef107e644043c6706a3d90018b0d7d8d43df4ea"><code>6ef107e</code></a> Revert &quot;Add docker rootless support for macOS and desktop for Linux (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6907">#6907</a>)&quot; ...</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/730f689aef771a3356246cd60b8efea655135da2"><code>730f689</code></a> Add test against Apache Cassandra 4 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/7013">#7013</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/cce90eb522e3117044e91537ad85804818bae8da"><code>cce90eb</code></a> [Enhancement]: Update waiting strategy for Mockserver container (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6951">#6951</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/ab90c0f3e7c99f742f4b4376d129b6e48147a673"><code>ab90c0f</code></a> Update RedpandaContainer (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6939">#6939</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/2ea0969f8c97f5e4d10dcbdc1553953ff56498d4"><code>2ea0969</code></a> Favor copy compose file instead of mount (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6945">#6945</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/6442d27bda2389c8615e24c65aadf9c3f292c247"><code>6442d27</code></a> Lowercase identifier in DockerComposeContainer (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6944">#6944</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/1a61543ea5925a1a960e34c470967370408cc912"><code>1a61543</code></a> Use the current thread's classloader for classes (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6926">#6926</a>)</li>
<li><a href="https://github.com/testcontainers/testcontainers-java/commit/b50cfee16ae15fea876a71b35f1c82d4d0cc51e5"><code>b50cfee</code></a> Update lombok version to 1.18.26 (<a href="https://redirect.github.com/testcontainers/testcontainers-java/issues/6935">#6935</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/testcontainers/testcontainers-java/compare/1.18.0...1.18.1">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.testcontainers:testcontainers-bom&package-manager=maven&previous-version=1.18.0&new-version=1.18.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

12751: deps(maven): bump spring-framework-bom from 6.0.8 to 6.0.9 r=github-actions[bot] a=dependabot[bot]

Bumps [spring-framework-bom](https://github.com/spring-projects/spring-framework) from 6.0.8 to 6.0.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/spring-projects/spring-framework/releases">spring-framework-bom's releases</a>.</em></p>
<blockquote>
<h2>v6.0.9</h2>
<h2>:star: New Features</h2>
<ul>
<li>Consistent support for MultiValueMap and common Map implementations in CollectionFactory <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30440">#30440</a></li>
<li>Introduce internal constants for implicit bounds in TypeUtils <a href="https://redirect.github.com/spring-projects/spring-framework/pull/30423">#30423</a></li>
<li>Update major/minor version properties in <code>MockServletContext</code> <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30395">#30395</a></li>
<li>Reject null and empty SpEL expressions <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30371">#30371</a></li>
<li>Support Test AOT processing with GraalVM tracing agent and Native Build Tools <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30281">#30281</a></li>
<li>Introduce <code>Environment.matchesProfiles()</code> for profile expressions <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30206">#30206</a></li>
<li>Optimize MultiValueMap iteration operations <a href="https://redirect.github.com/spring-projects/spring-framework/pull/29972">#29972</a></li>
</ul>
<h2>:lady_beetle: Bug Fixes</h2>
<ul>
<li>Respect TaskDecorator configuration on DefaultManagedTaskExecutor <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30442">#30442</a></li>
<li>Qualifiers registered programmatically are not supported by AOT <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30410">#30410</a></li>
<li>Support for <code>InjectionPoint</code> in bean factory methods when using AOT <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30401">#30401</a></li>
<li>Bean methods with generic array/varargs parameters break native compilation <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30407">#30407</a></li>
<li><code>ApplicationListenerMethodAdapter</code> supports non-matching generic events <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30399">#30399</a></li>
<li>Processing several <code>`@PersistenceContext</code>` injection points on the same class with AOT generates code that does not compile <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30437">#30437</a></li>
<li>Make maximum SpEL expression length configurable <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30380">#30380</a></li>
<li>Record beans do not compile to native images <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30383">#30383</a></li>
<li>Missing resource hint for <code>`@PropertySource</code>#value` <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30376">#30376</a></li>
<li>ApplicationEventPublisher - PayloadApplicationEvent not received by EventListener if event fired from child context <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30360">#30360</a></li>
<li>StringDecoder.decode() should release chunks on cancellation <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30299">#30299</a></li>
<li>Quote '?' in Quoted Printable filename <a href="https://redirect.github.com/spring-projects/spring-framework/pull/30252">#30252</a></li>
<li>Missing reflection hint for custom <code>PropertySourceFactory</code> in native image <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30175">#30175</a></li>
<li>Aot generated sources fail to compile with 'File name too long' error <a href="https://redirect.github.com/spring-projects/spring-framework/issues/29846">#29846</a></li>
</ul>
<h2>:notebook_with_decorative_cover: Documentation</h2>
<ul>
<li>Update <code>package-info</code> for CGLIB fork <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30461">#30461</a></li>
<li>Clarify differences between GenericBeanDefinition and RootBeanDefinition <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30444">#30444</a></li>
<li>Document how to configure FactoryBean with a configurable target with AOT <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30434">#30434</a></li>
<li>Add Antora docs-build branch <a href="https://redirect.github.com/spring-projects/spring-framework/pull/30415">#30415</a></li>
<li>Switch the reference documentation to Antora <a href="https://redirect.github.com/spring-projects/spring-framework/pull/30414">#30414</a></li>
<li><code>`@ResponseStatus</code>` documentation incorrect <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30305">#30305</a></li>
</ul>
<h2>:hammer: Dependency Upgrades</h2>
<ul>
<li>Upgrade to Micrometer 1.10.7 <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30451">#30451</a></li>
<li>Upgrade to Reactor 2022.0.7 <a href="https://redirect.github.com/spring-projects/spring-framework/issues/30450">#30450</a></li>
</ul>
<h2>:heart: Contributors</h2>
<p>Thank you to all the contributors who worked on this release:</p>
<p><a href="https://github.com/divcon"><code>`@​divcon</code></a>,` <a href="https://github.com/izeye"><code>`@​izeye</code></a>,` <a href="https://github.com/luozhenyu"><code>`@​luozhenyu</code></a>,` <a href="https://github.com/rwinch"><code>`@​rwinch</code></a>,` <a href="https://github.com/sigee"><code>`@​sigee</code></a>,` and <a href="https://github.com/yuzawa-san"><code>`@​yuzawa-san</code></a></p>`
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/spring-projects/spring-framework/commit/c9930dd831b6549bf8d24a8721b6e9222199422e"><code>c9930dd</code></a> Release v6.0.9</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/3f889e997cb8648f54e034c29e009960e8a086e3"><code>3f889e9</code></a> Clarify RootBeanDefinition vs GenericBeanDefinition</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/6622a3c7d6c475a5e205f49fe63eff0f569a4780"><code>6622a3c</code></a> Consistent package-info declarations for CGLIB fork</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/d8f6567c890340cfc145b8fa2766ccb4cf70fab2"><code>d8f6567</code></a> Download the playbook to build dir</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/111309605c7c1b4c4b8b40d7f8086a0e2338ca82"><code>1113096</code></a> Support Test AOT processing with GraalVM tracing agent and NBT</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/89bcee68bb0561a8f30b5c7fb34a067f54d028ae"><code>89bcee6</code></a> Add author tag</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/c8927ae7530a89657f1e70e92c92ae124d3aa485"><code>c8927ae</code></a> Polishing</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/e228f4ba6479694975c93e2f2a908ed91481bc65"><code>e228f4b</code></a> Consistent pre-resolution of event type vs payload type</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/c733ae0f22cacfa67398b6291a419867938a7475"><code>c733ae0</code></a> Fix ApplicationListenerMethodAdapter#supportsEventType check</li>
<li><a href="https://github.com/spring-projects/spring-framework/commit/aefcb9d2d6ee385c14d83852bee50b0307b42ce4"><code>aefcb9d</code></a> Make maximum SpEL expression length configurable</li>
<li>Additional commits viewable in <a href="https://github.com/spring-projects/spring-framework/compare/v6.0.8...v6.0.9">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.springframework:spring-framework-bom&package-manager=maven&previous-version=6.0.8&new-version=6.0.9)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

12752: deps(maven): bump software.amazon.awssdk:bom from 2.20.64 to 2.20.65 r=github-actions[bot] a=dependabot[bot]

Bumps software.amazon.awssdk:bom from 2.20.64 to 2.20.65.


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software.amazon.awssdk:bom&package-manager=maven&previous-version=2.20.64&new-version=2.20.65)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
zeebe-bors-camunda[bot] and dependabot[bot] authored May 12, 2023
4 parents 14e0aec + 56c24d9 + 0fd9edc + 5b6dee7 commit dcae6a2
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@
<version.wiremock>2.35.0</version.wiremock>
<version.conscrypt>2.5.2</version.conscrypt>
<version.asm>9.3</version.asm>
<version.testcontainers>1.18.0</version.testcontainers>
<version.testcontainers>1.18.1</version.testcontainers>
<version.netflix.concurrency>0.4.0</version.netflix.concurrency>
<version.zeebe-test-container>3.5.2</version.zeebe-test-container>
<version.feel-scala>1.16.0</version.feel-scala>
<version.dmn-scala>1.8.1</version.dmn-scala>
<version.rest-assured>5.3.0</version.rest-assured>
<version.spring>6.0.8</version.spring>
<version.spring>6.0.9</version.spring>
<version.spring-boot>3.0.5</version.spring-boot>
<version.concurrentunit>0.4.6</version.concurrentunit>
<version.kryo>5.4.0</version.kryo>
Expand All @@ -120,7 +120,7 @@
<version.zpt>8.1.9</version.zpt>
<version.feign>12.2</version.feign>
<version.google-sdk>26.11.0</version.google-sdk>
<version.awssdk>2.20.64</version.awssdk>
<version.awssdk>2.20.65</version.awssdk>
<version.toxiproxy>2.1.7</version.toxiproxy>
<version.validation-api>3.0.2</version.validation-api>
<version.jackson-databind-nullable>0.2.6</version.jackson-databind-nullable>
Expand Down

0 comments on commit dcae6a2

Please sign in to comment.