-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blackbox exporter charm #1
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Also need to:
- Update README
- Mention somewhere the existing charm?
- If you got time left for an adventure, consider unified charmcraft.yaml.
About the points made in a comment above:
|
This PR adds a first implementation of the Blackbox Exporter charm, including:
LogProxyConsumer
)There's some documentation in the README, but also on Charmhub Discourse:
All the relations have been manually tested, and here's a screenshot of the dashboard:
@simskij is taking care of claiming the blackbox-exporter-k8s charm name on Charmhub. If we merge the PR before that, we should run the release action again (manually) afterward, or manually publish the charm for the first time.