Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackbox exporter charm #1

Merged
merged 26 commits into from
Aug 31, 2023
Merged

blackbox exporter charm #1

merged 26 commits into from
Aug 31, 2023

Conversation

lucabello
Copy link
Contributor

@lucabello lucabello commented Aug 29, 2023

This PR adds a first implementation of the Blackbox Exporter charm, including:

  • basic charm skeleton;
  • Grafana dashboard integration (with a nice dashboard to monitor the probes executed by blackbox exporter)
  • Prometheus integration (self-monitoring AND periodic probes as a scrape job)
  • Loki integration (through LogProxyConsumer)
  • Catalogue integration (because why not)

There's some documentation in the README, but also on Charmhub Discourse:

All the relations have been manually tested, and here's a screenshot of the dashboard:

Screenshot_20230830_163550


@simskij is taking care of claiming the blackbox-exporter-k8s charm name on Charmhub. If we merge the PR before that, we should run the release action again (manually) afterward, or manually publish the charm for the first time.

@lucabello lucabello marked this pull request as ready for review August 29, 2023 15:29
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@sed-i sed-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Also need to:

.github/workflows/promote.yaml Outdated Show resolved Hide resolved
.wokeignore Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
config.yaml Outdated Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
src/blackbox.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
src/charm.py Show resolved Hide resolved
@lucabello lucabello requested a review from sed-i August 31, 2023 09:45
@lucabello
Copy link
Contributor Author

About the points made in a comment above:

  • README updated ✅
  • I don't think it's necessary to mention that charm because it's a machine charm; sure we could link to it in the README, but I doubt it matters since this is meant to replace it
  • I have the feeling the "unified charmcraft.yaml" could (e.g. would) break our CI, so I'll pass on that one 😄

config.yaml Show resolved Hide resolved
@lucabello lucabello requested a review from sed-i August 31, 2023 19:03
@lucabello lucabello merged commit b768092 into main Aug 31, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants