-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploration for Kubeflow Dashboard (HTTPs) how-to guide #955
Comments
Thank you for reporting us your feedback! The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5919.
|
Today I went through this guide and made some more experiments on my side to answer some questions from the parent epic. The guide was nicely written but still does not answer all the questions from Acceptance criteria section (listed and described bellow). To sum up there are following charms:
Today I went through the first two options. To test the third option we need to register a name for our kubeflow deployment with the CA authority which will provide the ACME servers. Should we do this in our explanation guide? Rest on the answers today are based on the first two charms. I can enable and disable the TLSThis is done easily by relating and un-relating the provider charm with istio-pilot. We can write a short section about that in final doc. I can read about the benefits of using the TLSWe can add section explaining benefits of HTTPs over HTTP (e.g. from here). I can read about the versions of Kubeflow that TLS worksToday I tested on 1.8 and latest/beta I can read about the environment (on prem, cloud) which TLS worksIn both cases the setup can be simply accomplished with the second charm by providing the certificates manually. The setting with ACME might be problematic, but each of those ACME charms have tutorials explaining details (e.g. for route 53 AWS). I can change the TLS certificate if neededThe same way I provide certificate in the second charm the same way I can update. For the ACME this is handled by the ACME server. I can read about for how long it is available (or when it expire)This is hard to answer in second charm user creates the certificate and they decide how long it will be available. In third group of charms its the setting of the ACME server. I can read about possible constraintsNot sure about constraints will need to sync with team I can integrate with a TLS providerWhat provider? Should we really do this in kubeflow guide? The setting of provider can be really specific. I can read about examples of TLS providers that can be integrated with / usedSame as above Test 1 self-signed-certificates-operator
Test 2 self-signed-certificates-operator
|
Sync with @kimwnasptd Using Clouds k8s (EKS AKS)
|
So how managed solution handles HTTPS in Azure
Rotation:
The TLS for dynamic dns in azure is 12 second ... so every 3 months there is a chance for 12 seconds that the user will see welcome to the nginx message :) Notes AWS |
At the end we agreed
|
Hey @misohu @kimwnasptd I can see the section of how to integrate with TLS certificates providers was removed, but it is not clear to me why it was removed. Do you mind sharing the arguments in favour of not exposing this information? Also, I have some notes for the published guide:
@kimwnasptd did this changed recently?
This section is confusing. I'd suggest we change the title to "Migrating from configuration to juju secret". Also, this paragraph is not clear:
This section is supposed to help people migrate from the old configuration implementation (passing values to ssl-key and ssl-crt config options) to the new one, passing those values as a juju secret, but this first paragraph does not make this clear (at least it does not to me). Maybe rephrase it a bit so it is clear why and when people have to do it? You can get inspiration from the old guide. |
Hey @DnPlas ... The charms section was removed because currently none of them are usable (tested on azure cloud). Here I will put again the issues describing the problems with those charms
Moreover none of the charms provides guides on how to set them up with any certificate provider. The only way to setup https which was tested was through the configuration on istio-pilot. With @kimwnasptd we decided to keep only that part |
Context
Explore the implementation needed for https://warthogs.atlassian.net/browse/KF-5665
What needs to get done
Explore how the implementation needed can be achieved in order to be able then to write a how-to guide
Definition of Done
Exploration has been done and findings are documented in the issue.
The text was updated successfully, but these errors were encountered: