Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles should also be added via JS #39

Open
barrymcgee opened this issue May 1, 2019 · 3 comments
Open

Styles should also be added via JS #39

barrymcgee opened this issue May 1, 2019 · 3 comments
Labels
Priority: Low

Comments

@barrymcgee
Copy link
Contributor

This would mean users can just install the package, call it and be done.
@anthonydillon anthonydillon removed their assignment Jun 3, 2019
@steverydz
Copy link
Contributor

Hopefull this will be addressed in #15 but we should keep this open for now.

@carkod
Copy link
Contributor

carkod commented May 9, 2022 •
edited
Loading

@steverydz has this been addressed? the PR is merged

@steverydz
Copy link
Contributor

@steverydz has this been address? the PR is merged

@carkod I haven't seen a PR for this but from looking at the code it seems that the styles aren't added with JS. The idea to turn it into a web component was dropped which is why the issue I reference was closed. I don't know if there are any plans to action this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steverydz @barrymcgee @anthonydillon @tbille @carkod