Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication for /alive endpoint #57

Closed
przemeklal opened this issue Oct 27, 2023 · 2 comments
Closed

Authentication for /alive endpoint #57

przemeklal opened this issue Oct 27, 2023 · 2 comments

Comments

@przemeklal
Copy link
Member

Enhancement Proposal

Currently:

  • client ID (potentially sensitive) is sent over the network, without native TLS support in cos-alerter this means sending sensitive data unencrypted
  • even with HTTPS enabled, a malicious actor can send a valid client ID to the /alive endpoint and pretend to be an active alertmanager instance while the actual instance may be down

Potential solutions:

  • TLS support + a pre-shared secret (password) included in the client POST requests sent to /alive (ins tead of sending only client ID that may be easy to guess)
  • sending a token in the POST request and mapping that token to a client ID in cos-alerter.yaml config
  • mutual TLS (might be an overkill)
@lucabello
Copy link
Contributor

We've implemented authentication using a client ID. Without TLS however this isn't secure; once TLS is implemented this can be closed.

@lucabello lucabello mentioned this issue Dec 7, 2023
@lucabello
Copy link
Contributor

Closing this in favor of #59, so we can track the progress in a single place.

@lucabello lucabello closed this as not planned Won't fix, can't repro, duplicate, stale Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants