fix(security-key) improve ux when email does not have a security key set up #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edlerd
force-pushed
the
security-key-method
branch
3 times, most recently
from
1f82aca to
0509b1a
Compare
BarcoMasile
reviewed
Dec 18, 2024
…set up. fixes canonical#383 Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
security-key-method
branch
from
0509b1a to
db631fb
Compare
BarcoMasile
approved these changes
Dec 18, 2024
nsklikas
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Code looks fine, BUT I think that the UX on this feels weird.
Intuitively the email and password are used when clicking the Sign in button. But it turns out that the email is used also when clicking the Sign in with passkey button.
This feels like inconsistent behavior, why don't we also send the email to the idp when the user logs in using oidc?
I wasn't aware there is a way to send the email when starting the flow with an OIDC provider. I'd consider it out of scope of the bug for this PR. We can create an issue with improvement tag for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #383