Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Permission denied exception in charm and test code #420

Open
DnPlas opened this issue May 28, 2024 · 1 comment
Open

Update Permission denied exception in charm and test code #420

DnPlas opened this issue May 28, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DnPlas
Copy link
Contributor

DnPlas commented May 28, 2024

Context

#401 introduces the use of user secrets for configuring the TLS ingress Gateway, but because of canonical/operator#1229 and https://bugs.launchpad.net/juju/+bug/2067336, the behaviour of the exception that gets raised when access to a secret hasn't been granted is inconsistent. We are not holding #401 any more from being merged, so we have to make sure we come back and change the istio-pilot charm code and unit test accordingly.

What needs to get done

  1. Update the test_use_https_with_tls_secret_permission_denied unit test code with an assertion that checks the message on the described scenario
  2. Update the _use_https_with_tls_secret method in the charm code to catch the right exception (seems like it'll be the SecretNotFound exception) and handle it accordingly

Definition of Done

The _use_https_with_tls_secret method gets tested with test_use_https_with_tls_secret_permission_denied with the actual Juju behaviour after https://bugs.launchpad.net/juju/+bug/2067336 is fixed.

@DnPlas DnPlas added the enhancement New feature or request label May 28, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5743.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant