Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web app doesn't pick Template ConfigMaps because they miss labels #136

Open
kimwnasptd opened this issue Sep 6, 2023 · 2 comments
Open
Labels
bug Something isn't working

Comments

@kimwnasptd
Copy link
Contributor

Bug Description

Right now the katib-web-app will not allow users to select a TrialTemplate, when creating a new Experiment, even though we do deploy TrialTemplates as configmap

"trial-template": {
f
+ suffix: render_template(
f"src/templates/{f}.yaml.j2", self.images_context
)
for f, suffix in (
("defaultTrialTemplate", ".yaml"),
("enasCPUTemplate", ""),
("pytorchJobTemplate", ""),
)
},
},
},
)

image

To Reproduce

Deploy latest track/0.15 Katib Charms (controller and ui)

Environment

latest/edge as well as track/0.15

Relevant Log Output

No logs from Charms or the app

Additional Context

No response

@kimwnasptd
Copy link
Contributor Author

This is because the backend of the Katib web app will only filter ConfigMaps that have a label katib.kubeflow.org/component: trial-templates
https://github.com/kubeflow/katib/blob/e3e0aa24aeea1edfab0fd42f55392af651d2b3ae/pkg/util/v1beta1/katibclient/katib_client.go#L169

But we don't add any labels when we create the ConfigMap. We'll need to update our Charm to add this label to created ConfigMap

@kimwnasptd
Copy link
Contributor Author

we found this while looking into having one simple TrialTemplate in CKF for #132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Labeled
Development

No branches or pull requests

2 participants