Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream TableCaption from MSM MAASENG-2987 #127

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

ndv99
Copy link
Collaborator

@ndv99 ndv99 commented Apr 12, 2024

Done

  • Upstreamed TableCaption from MSM

QA steps

  • Go to /?path=/docs/components-tablecaption--docs
  • Ensure the component is displayed correctly across all breakpoints

Fixes

Fixes MAASENG-2987

Screenshots

image

@ndv99 ndv99 requested a review from petermakowski April 12, 2024 09:04
@webteam-app
Copy link
Collaborator

@petermakowski
Copy link
Contributor

I just noticed that .u-visually-hidden for DynamicTable.Loading is missing, could you add that please.

Co-authored-by: Peter Makowski <me+github@petermakowski.io>
@ndv99 ndv99 enabled auto-merge (squash) April 12, 2024 09:28
@ndv99 ndv99 merged commit 30e9dfd into canonical:main Apr 12, 2024
5 checks passed
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants