feat: add ExternalLink component #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermakowski
force-pushed
the
feat-add-external-link
branch
2 times, most recently
from
9ec5d63 to
0696f9c
Compare
petermakowski
force-pushed
the
feat-add-external-link
branch
from
0696f9c to
3b97d63
Compare
ndv99
approved these changes
Oct 16, 2023
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
ExternalLinkcomponentQA steps
Screenshots
Notes
In case you happen to have errors about different react versions/breaking rules of hooks you may need to run
yarn link ../maas-ui/node_modules/reactin themaas-react-componentslocal repository to make sure it resolves to the correct version.https://react.dev/warnings/invalid-hook-call-warning#duplicate-react