Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase specificity of pointer cursor rule #38

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: increase specificity of pointer cursor rule #38

merged 2 commits into from
Nov 23, 2023

Conversation

ndv99
Copy link
Collaborator

@ndv99 ndv99 commented Nov 23, 2023 •
edited by Jay-Topher
Loading

Done

  • Increased specificity of cursor: pointer rule

This was done since there were some conflicts with base vanilla styles, meaning that this did not work in MAAS UI or Site Manager.

QA steps

  • Run storybook
  • Go to navigation example
  • Open dev tools
  • Use element selector to select active link
  • Toggle hover state to on
  • Ensure selector containing rule to set cursor to pointer has specificity of (0,5,0)

Jay-Topher
Jay-Topher approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Jay-Topher Jay-Topher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ndv99 ndv99 enabled auto-merge (squash) November 23, 2023 16:11
@ndv99 ndv99 merged commit 3715375 into canonical:main Nov 23, 2023
5 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jay-Topher Jay-Topher Jay-Topher approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndv99 @Jay-Topher