Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multi select component #56

Conversation

petermakowski
Copy link
Contributor

@petermakowski petermakowski commented Jan 9, 2024

Done

This adds a multi select component and introduces an internal FadeInDown component for handling fade in transitions. This is experimental and should be used internally only for now.

  • feat: add multi select component

This component matches image provisioning design (with the exception of adding the search input field for filtering of options)

QA steps

  • Go to the example page ?path=/story/components-multiselect--example
  • Ensure the component is displayed correctly across all breakpoints
  • Click on a label
  • Make sure the list box has been opened
  • Make sure you can select and remove items
  • Go to NestedFormGroup and ensure it expands and collapses as before
  • Make sure component matches image provisioning design (with the exception of adding the search input field for filtering of options)

Fixes

Fixes: MAASENG-2534

Screenshots

Google Chrome screenshot 001324@2x
Google Chrome screenshot 001326

Notes

@petermakowski petermakowski force-pushed the feat-add-complex-combobox-MAASENG-2534 branch from 06fe3bf to 0033f6b Compare January 9, 2024 14:51
@petermakowski petermakowski changed the title feat: add multi select component feat: add multi select component WIP Jan 9, 2024
@petermakowski petermakowski force-pushed the feat-add-complex-combobox-MAASENG-2534 branch from 0033f6b to 6863646 Compare January 11, 2024 12:30
@petermakowski petermakowski force-pushed the feat-add-complex-combobox-MAASENG-2534 branch from 6863646 to 396b1e8 Compare January 11, 2024 12:36
@petermakowski petermakowski changed the title feat: add multi select component WIP feat: add multi select component Jan 11, 2024
@petermakowski petermakowski marked this pull request as ready for review January 11, 2024 12:38
Copy link
Collaborator

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, LGTM!

@petermakowski petermakowski merged commit 6c3bafa into canonical:main Jan 11, 2024
11 checks passed
Copy link

🎉 This PR is included in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants