Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Pebble layers in testing get_plan; merge "checks" and "log-targets" #1112

Closed
benhoyt opened this issue Jan 23, 2024 · 1 comment · Fixed by #1268
Closed

Combine Pebble layers in testing get_plan; merge "checks" and "log-targets" #1112

benhoyt opened this issue Jan 23, 2024 · 1 comment · Fixed by #1268
Assignees
Labels
24.10 bug Something isn't working small item

Comments

@benhoyt
Copy link
Collaborator

benhoyt commented Jan 23, 2024

As I discovered when reviewing #1111 (comment), we don't combine layers properly in the _TestingPebbleClient.get_plan result.

We already kind of have the code to combine a layer (in _TestingPebbleClient.add_layer), we just need to use it for get_plan as well.

Additionally, we need to combine/merge health checks and log targets. We have pebble.Service._merge (used by add_layer above), but we'll need similar _merge methods on pebble.Check and pebble.LogTarget and update appropriately.

@amandahla
Copy link
Contributor

Hi, I've come across this issue while working on this PR:
canonical/synapse-operator#404

Is there another way of creating a unit test for check changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.10 bug Something isn't working small item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants