Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Secret.id includes model UUID #1312

Closed
benhoyt opened this issue Aug 12, 2024 · 0 comments · Fixed by #1358
Closed

Ensure Secret.id includes model UUID #1312

benhoyt opened this issue Aug 12, 2024 · 0 comments · Fixed by #1358

Comments

@benhoyt
Copy link
Collaborator

benhoyt commented Aug 12, 2024

Currently Secret._canonicalize_id adds the secret: prefix if it's not there, but it doesn't add the model UUID. It would be helpful if it added the model UUID too, especially for cross-model relations. See more information at https://bugs.launchpad.net/juju/+bug/2075153

# Current logic:
id if id.startswith('secret:') else f'secret:{id}'

# Change it to something like:
id if id.startswith('secret:') else f'secret://{model_uuid}/{id}'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant