Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let's go, Travis. #3

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Let's go, Travis. #3

merged 2 commits into from
Oct 1, 2019

Conversation

niemeyer
Copy link
Collaborator

@niemeyer niemeyer commented Oct 1, 2019

No description provided.

@dshcherb
Copy link
Contributor

dshcherb commented Oct 1, 2019

Needs __init__.py.

johnsca
johnsca suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis ran 0 tests. See comment below.

.travis.yml
- "3.7"

script:
- python3 -m unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be:

PYTHONPATH=test python3 -m unittest test_framework

Example output:

.............
----------------------------------------------------------------------
Ran 13 tests in 0.146s

OK

johnsca
johnsca approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@johnsca johnsca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nm, the __init__.py fixed it as well.

@niemeyer niemeyer merged commit 4efd6f4 into canonical:master Oct 1, 2019
@niemeyer niemeyer deleted the travis-support branch October 1, 2019 16:00
@pengale pengale mentioned this pull request Jul 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsca johnsca johnsca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niemeyer @dshcherb @johnsca