Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapcraft 8.2.0.post3+gitc9ab9d1d from edge doesn't support refresh-mode: ignore-running #4747

Closed
kenvandine opened this issue Apr 19, 2024 · 4 comments · Fixed by #4749
Closed
Labels
bug Actual bad behavior that don't fall into maintenance or documentation

Comments

@kenvandine
Copy link
Contributor

Bug Description

The documentation shows ignore-running as a valid option for refresh-mode

https://snapcraft.io/docs/snapcraft-app-and-service-metadata

However when building snapcraft reports:

unexpected value; permitted: 'endure', 'restart'

To Reproduce

Add "refresh-mode: ignore-running" to the app

Environment

snapcraft from edge with lxd

snapcraft.yaml

+    refresh-mode: ignore-running

Relevant log output

unexpected value; permitted: 'endure', 'restart'

Additional context

No response

@kenvandine kenvandine added the bug Actual bad behavior that don't fall into maintenance or documentation label Apr 19, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-2834.

This message was autogenerated

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 19, 2024

Thanks for the report! I can reproduce this in snapcraft 7.x/stable and 8.x/stable with core20 and core22.

@kenvandine, was this previously working for you?

It appears that it should have never worked (source and source). Here's my core22 reproducer:

name: test
version: '0.1'
summary: test
description: test

grade: devel
confinement: devmode

base: core22

parts:
  my-part:
    plugin: nil
    override-build: |
      touch $CRAFT_PART_INSTALL/hello
      chmod +x $CRAFT_PART_INSTALL/hello
      craftctl default

apps:
  my-app:
    command: hello
    refresh-mode: ignore-running

@kenvandine
Copy link
Contributor Author

No, I didn't know about it until I just stumbled upon it in the docs and thought it could solve a problem we have right now.

@mr-cal
Copy link
Collaborator

mr-cal commented Apr 19, 2024

Great, I was hoping for. I'll update the models to allow ignore-running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Actual bad behavior that don't fall into maintenance or documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants