Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for chip links #5317

Closed
juanruitina opened this issue Aug 21, 2024 · 2 comments · Fixed by #5347
Closed

Add support for chip links #5317

juanruitina opened this issue Aug 21, 2024 · 2 comments · Fixed by #5347
Labels
Bug 🐛 P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4

Comments

@juanruitina
Copy link

Describe the bug

Chip styles don't work great when p-chip is applied to an a element instead of a button. I'd expect the same hover styles than the button: that means slightly darker background and no underline.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://vanillaframework.io/docs/patterns/chip
  2. Turn any chip into an a element
  3. Hover
  4. See error

Expected behavior

No styling difference between links and buttons

Screenshots

Screenshot 2024-08-21 at 17 07 47
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14348.

This message was autogenerated

@juanruitina juanruitina mentioned this issue Aug 21, 2024
Merged
@jmuzina jmuzina mentioned this issue Sep 12, 2024
Merged
3 tasks
@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4 labels Sep 25, 2024
@bartaz
Copy link
Member

bartaz commented Sep 25, 2024

This is already in progress, and should be a low effort fix. Triaging for current codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: v4 Triaged, to be implemented as part of Vanilla v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for chip links jmuzina/vanilla-framework
2 participants
@bartaz @juanruitina