cstool has dependency in static library but there is logical inconsistency in options

[gdbinit]

If CAPSTONE_STATIC=NO is passed to make.sh the build will fail because cstool has dependency on libcapstone.a static library.

The only check made is when CAPSTONE_BUILD_CORE_ONLY is used for macOS kernel version and kind of is internal option only (not referred in documentation).

Does it make it sense to put a fix for this to not build cstool if CAPSTONE_STATIC=NO is set or is it just an implicit assumption and not relevant?

[XVilka]

@Rot127 what do you think on this one. I personally think cstool should be independent of the type of the library it built with - static or dynamic, it should work in both cases.

[Rot127]

what do you think on this one. I personally think cstool should be independent of the type of the library it built with - static or dynamic, it should work in both cases.

I agree. Though @kabeor mentioned often now that make.sh will not be supported anymore and only the cmake build will be maintained.

Using cmake one should be able to compile cstool statically or dynamically as they wish.

capstone/CMakeLists.txt

Lines 35 to 39 in a026fc4

	# to configure the options specify them in in the command line or change them in the cmake UI.
	# Don't edit the makefile!
	option(BUILD_SHARED_LIBS "Build shared library" OFF)
	option(CAPSTONE_BUILD_STATIC_RUNTIME "Embed static runtime" ${BUILD_SHARED_LIBS})
	option(CAPSTONE_BUILD_DIET "Build diet library" OFF)

[XVilka]

As the make.sh file is still here in 5.0, it's probably better to fix this. And if it's deprecated, better to remove it completely in the 6.0, for example.

[Rot127]

Wasn't the make way of building to be removed anyway? @kabeor You mentioned this several times I think.

[XVilka]

@kabeor @aquynh what should we do with that? Ideally, it would be nice to fixed, should we remove it?

[kabeor]

Well for me, I just leave Makefile there and no plan to touch it. It's so complicated to contributors (always updating every building way which causes a lot of unnecessary confusion). But don't remove it, if anyone would like to maintain Makefile way, welcome. CMake way is the first tier in the future for Capstone.

[XVilka]

Should be this closed then as there are no plans to fix it? @kabeor

[Rot127]

Close this one now because the make build is considered deprecated. Especially with v6 Alpha coming.