-
Notifications
You must be signed in to change notification settings - Fork 665
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch to postcss to use uri optimization plugin
- Loading branch information
1 parent
cb3ee6b
commit f9f6990
Showing
3 changed files
with
51 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
plugins: [require("./scripts/postcss-optimize-data-uri-pngs")], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
const postcss = require("postcss"); | ||
const dataUriToBuffer = require("data-uri-to-buffer"); | ||
const imagemin = require("imagemin"); | ||
const imageminOptipng = require("imagemin-optipng"); | ||
|
||
const DATA_URL_REGEX = new RegExp(/url\((data:image\/png;base64,.+)\)/gi); | ||
const DATA_URL_PROPS_REGEX = /^(background(?:-image)?)|(content)|(cursor)/; | ||
|
||
async function optimizeDataUri(dataUri) { | ||
const buffer = dataUriToBuffer(dataUri); | ||
const optimized = await imagemin.buffer(buffer, { | ||
use: [imageminOptipng()], | ||
}); | ||
return `data:image/png;base64,${optimized.toString("base64")}`; | ||
} | ||
|
||
module.exports = postcss.plugin("postcss-optimize-data-uri-pngs", () => { | ||
return async function (css) { | ||
// walkDecls does not let us work async, so we collect the async work we | ||
// need to do here, and await it at the end | ||
const promisesFactories = []; | ||
css.walkDecls(DATA_URL_PROPS_REGEX, (decl) => { | ||
let matches; | ||
// WTF JavaScript. This is the worst API for iterating RegEx matches. | ||
while ((matches = DATA_URL_REGEX.exec(decl.value))) { | ||
const [, dataUri] = matches; | ||
promisesFactories.push(async () => { | ||
decl.value = decl.value.replace( | ||
dataUri, | ||
await optimizeDataUri(dataUri) | ||
); | ||
}); | ||
} | ||
}); | ||
await Promise.all(promisesFactories.map((p) => p())); | ||
}; | ||
}); |
11 changes: 11 additions & 0 deletions
11
packages/webamp/scripts/postcss-optimize-data-uri-pngs.test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
const fs = require("fs"); | ||
const postcss = require("postcss"); | ||
|
||
const plugin = require("./postcss-optimize-data-uri-pngs"); | ||
|
||
const css = fs.readFileSync("./css/base-skin.css", "utf8"); | ||
// This seems to timeout a lot in CI | ||
it.skip("does something", async () => { | ||
const result = await postcss([plugin({})]).process(css); | ||
expect(result.css.length).toBeLessThan(css.length); | ||
}); |