Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadcrumb] refactor hasOverflow to use implementation from Carbon #1737

Open
1 of 2 tasks
tay1orjones opened this issue Oct 29, 2020 · 0 comments
Open
1 of 2 tasks
Labels
dependent on: carbon Items present upstream in Carbon Design System package: react type: enhancement 💡 New feature or request type: repo/dx 💻

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Oct 29, 2020

What package is this for?

  • React
  • Angular

Summary

The Carbon team is updating the breadcrumb to have first-party support for the overflow menu. We'll need to make some changes to our hasOverflow implementation to take advantage of the feature now provided by the base component.

Note that this is only support for the overflow menu - we'll need to retain our feature of automatically adding/removing items in to and out of the overflow menu on browser resize.

Additional context
Carbon PR: carbon-design-system/carbon#7085

Specific timeline issues / requests

This will probably be contained as part of an upgrade of our Carbon dependencies. Potentially v10.23.0 (#1702), but more likely v10.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent on: carbon Items present upstream in Carbon Design System package: react type: enhancement 💡 New feature or request type: repo/dx 💻
Projects
None yet
Development

No branches or pull requests

2 participants