fix(core): export patterns as strings of svgs #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theiliad
previously requested changes
Mar 26, 2019
|
Deploy preview for carbon-charts ready! Built with commit 5c2b53d |
theiliad
previously approved these changes
Mar 26, 2019
theiliad
approved these changes
Mar 26, 2019
| @@ -35,6 +35,9 @@ | |||
| "prettier": "1.16.4", | |||
| "vue-template-compiler": "2.5.21" | |||
| }, | |||
| "publishConfig": { | |||
There was a problem hiding this comment.
Right, for scoped packages, I wonder why this wasn't included in our initial vue PRs
There was a problem hiding this comment.
I didn't notice it, and the vue cli didn't generate it 😕 in the future It'd be great to have some tooling take care of that kind of project syncing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after_successfrom travis.yml ... it's not needed at this point