Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement CvForm, CvFormGroup and CvFormItem #1452

Merged
merged 5 commits into from
May 16, 2023

Conversation

felipebritor
Copy link
Contributor

Contributes to #1451

What did you do?

CvForm, CvFormGroup and CvFormItem implementation for vue3, following vue2 implementation and react-carbon v7 as base

How have you tested it?

Using both unit tests and through the stories

Were docs updated if needed?

  • Yes

@felipebritor felipebritor changed the title freat: implement CvForm, CvFormGroup and CvFormItem feat: implement CvForm, CvFormGroup and CvFormItem Apr 19, 2023
Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
The only thing I see is that the "Submit" button in the storybook actually open a new page. Looking at the Vue 2 version, the storybook has:

<cv-form @submit.prevent="actionSubmit">

Could you add something like that?

@felipebritor
Copy link
Contributor Author

felipebritor commented May 14, 2023

Nice work! The only thing I see is that the "Submit" button in the storybook actually open a new page. Looking at the Vue 2 version, the storybook has:

<cv-form @submit.prevent="actionSubmit">

Could you add something like that?

Sorry about it, @davidnixon. Rebased the last commit to fix it, thanks!

@kodiakhq kodiakhq bot merged commit d93b825 into carbon-design-system:vNext May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants