Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit-avt1-homepage: more than one banner role #1409

Closed
andreancardona opened this issue Jul 22, 2020 · 1 comment · Fixed by #1477
Closed

audit-avt1-homepage: more than one banner role #1409

andreancardona opened this issue Jul 22, 2020 · 1 comment · Fixed by #1477
Assignees

Comments

@andreancardona
Copy link
Contributor

andreancardona commented Jul 22, 2020

Environment:

Operating system: Mac
Browser: Chrome
AVT 1️⃣
Page: Homepage

Detailed Description:

There is more than one element with "banner" role on the page.

What to do:

Remove "banner" role from all but one element. (The

element has an implicit role of banner when it is a descendent of the body element.)

Why is this important?

When more than one "banner" landmark role is used on a web page, it can confuse people who use assistive technologies that rely on this information to easily navigate the various sections in the page.

@andreancardona
Copy link
Contributor Author

Screen Shot 2020-07-23 at 11 30 26 AM

Most sense: wrap BLM header into Carbon header
One solution - give BLM and Carbon header unique IDs
Other solution is to turn BLM header into a div

Also remove aria-label="Header" on header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant