fix: added role option to selectabletag and changed stories (#17110)

* fix: added role option to selectabletag and changed stories * fix: added aria-pressed instead of aria-selected * test: fixed avt test that was failing * fix: fixed selectalbe tag --------- Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
carbon-design-system · Aug 9, 2024 · 5172f69 · 5172f69
1 parent 76ebd21
commit 5172f69
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/e2e/components/ProgressIndicator/ProgressIndicator-test.avt.e2e.js b/e2e/components/ProgressIndicator/ProgressIndicator-test.avt.e2e.js
@@ -113,8 +113,8 @@ test.describe('@avt ProgressIndicator', () => {
       },
     });
     // Testing the first element interaction
-    await page.keyboard.press('Tab');
     await expect(page.getByRole('button', { name: 'Click me' })).toBeVisible();
+    await page.keyboard.press('Tab');
     await expect(page.getByRole('button', { name: 'Click me' })).toBeFocused();
 
     await page.keyboard.press('Enter');

diff --git a/packages/react/src/components/Tag/SelectableTag.tsx b/packages/react/src/components/Tag/SelectableTag.tsx
@@ -118,6 +118,7 @@ const SelectableTag = <T extends React.ElementType>({
         leaveDelayMs={0}
         onMouseEnter={() => false}>
         <Tag
+          aria-pressed={selectedTag}
           ref={tagRef}
           slug={slug}
           size={size}
@@ -138,6 +139,7 @@ const SelectableTag = <T extends React.ElementType>({
 
   return (
     <Tag
+      aria-pressed={selectedTag}
       ref={tagRef}
       slug={slug}
       size={size}