Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid inputs: FluidMultiSelect #12124

Closed
2 of 12 tasks
Tracked by #5416
, #559
...
tay1orjones opened this issue Sep 20, 2022 · 0 comments · Fixed by #12163
Closed
2 of 12 tasks
Tracked by #5416
, #559
...

Fluid inputs: FluidMultiSelect #12124

tay1orjones opened this issue Sep 20, 2022 · 0 comments · Fixed by #12163
Assignees
@tw15egan
Labels
package: @carbon/react @carbon/react role: design ✏️ role: dev 🤖 type: enhancement 💡
Milestone
2022 Q4

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Sep 20, 2022 •
edited by aagonzales
Loading

This issue is for the primary implementation and design of the FluidMultiSelect component.

Checklist

  • Fluid inputs: MultiSelect docs carbon-website#3172
    • Update "style" and "usage" tabs of component page to include Fluid variant
  • [Figma] Add "Fluid-input: MultiSelect" carbon-design-kit#577
  • Fluid inputs: Add FluidMultiSelect experimental implementation
    • Place implementation within a new component, FluidComponentName
    • Add VRT tests via storybook story e2e setup
    • Add unit tests (likely simple, eg. "does the classname get added")
    • Add storybook example
    • Add it to the FluidForm story
    • Ensure styles are properly scoped to their own file
    • Add component: FluidMultiSelect label to repo for triaging issues
  • Fluid inputs: FluidMultiSelectSkeleton?

Spec

Sketch file | Figma file

MultiSelect - White
@tay1orjones tay1orjones mentioned this issue Sep 20, 2022
Closed
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Sep 20, 2022
@tay1orjones tay1orjones added this to the 2022 Q4 milestone Sep 20, 2022
@tay1orjones tay1orjones assigned tw15egan and abbeyhrt and unassigned abbeyhrt Sep 26, 2022
@tay1orjones tay1orjones moved this from ⏱ Backlog to 🏗 In Progress in Design System Sep 27, 2022
@tw15egan tw15egan mentioned this issue Oct 6, 2022
Merged
@tay1orjones tay1orjones moved this from 🏗 In Progress to 🚦 In Review in Design System Oct 6, 2022
@kodiakhq kodiakhq bot closed this as completed in #12163 Oct 21, 2022
Repository owner moved this from 🚦 In Review to ✅ Done in Design System Oct 21, 2022
This was referenced Dec 1, 2022
Closed
Closed
@aagonzales aagonzales mentioned this issue Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
package: @carbon/react @carbon/react role: design ✏️ role: dev 🤖 type: enhancement 💡
Projects
Design System
Archived in project
Milestone
2022 Q4
Development

Successfully merging a pull request may close this issue.

feat(Listbox): add in FluidComboBox, FluidMultiSelect tw15egan/carbon
3 participants
@tay1orjones @tw15egan @abbeyhrt