Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button: Update types to be a conditional proptype (or a union in TS) of if hasIconOnly, kind !== "danger" #17036

Closed
Tracked by #14300
tay1orjones opened this issue Jul 24, 2024 · 1 comment · Fixed by #17272
Closed
Tracked by #14300

Button: Update types to be a conditional proptype (or a union in TS) of if hasIconOnly, kind !== "danger" #17036

tay1orjones opened this issue Jul 24, 2024 · 1 comment · Fixed by #17272
Assignees
@ariellalgilmore
Labels
component: button package: @carbon/react @carbon/react role: dev 🤖
Milestone
2024 Q3

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Jul 24, 2024 •
edited
Loading

danger is not a valid type of IconButton or <Button hasIconOnly/>, we need to update the proptypes and TS interfaces to state this.
@tay1orjones tay1orjones mentioned this issue Jul 24, 2024
Open
@tay1orjones tay1orjones changed the title Update Button types to be a conditional proptype (or a union in TS) of if hasIconOnly, kind !== "danger" Button: Update types to be a conditional proptype (or a union in TS) of if hasIconOnly, kind !== "danger" Jul 24, 2024
@tay1orjones tay1orjones moved this to ⏱ Backlog in Design System Jul 24, 2024
@tay1orjones tay1orjones added this to the 2024 Q3 milestone Jul 24, 2024
@Gururajj77
Copy link
Contributor

This article could give more insight on this issue:
https://typeofnan.dev/conditional-component-props-react/

@ariellalgilmore ariellalgilmore self-assigned this Aug 23, 2024
@ariellalgilmore ariellalgilmore mentioned this issue Aug 26, 2024
Merged
@ariellalgilmore ariellalgilmore moved this from ⏱ Backlog to 🚦 In Review in Design System Aug 28, 2024
@github-project-automation github-project-automation bot moved this from 🚦 In Review to ✅ Done in Design System Sep 12, 2024
@albert-schilling albert-schilling mentioned this issue Dec 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
component: button package: @carbon/react @carbon/react role: dev 🤖
Projects
Design System
Archived in project
Milestone
2024 Q3
Development

Successfully merging a pull request may close this issue.

fix(button): update types hasIconOnly & kind !== danger ariellalgilmore/carbon
3 participants
@tay1orjones @ariellalgilmore @Gururajj77