Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audit] File uploader #2043

Closed
laurenmrice opened this issue Mar 11, 2019 · 7 comments
Closed

[Audit] File uploader #2043

laurenmrice opened this issue Mar 11, 2019 · 7 comments
Assignees
@dakahn @laurenmrice
Labels
role: dev 🤖 version: 10 Issues pertaining to Carbon v10
Milestone
v10.0-rc1

Comments

@laurenmrice
Copy link
Member

Component
File Uploader - White theme.png

Specs:
File uploader - Specs - White theme.png

**Sketch file:**https://ibm.ent.box.com/file/342710803221
@laurenmrice laurenmrice added this to the v10.0-rc1 milestone Mar 11, 2019
@laurenmrice
Copy link
Member Author

Changes:

  • The 'Add file' button needs to be 48px instead of 32px.
  • The background for the uploaded file isn't showing up currently. Screen Shot 2019-03-11 at 10.43.50 AM.png

@dakahn
Copy link
Contributor

dakahn commented Mar 11, 2019

Checked on both the latest FF and and Chrome in both Windows 10 and OS X and I can't reproduce the missing background for the uploaded file. 😕 @laurenmrice

@laurenmrice
Copy link
Member Author

@IBM/carbon-developers Anyone know how to get around this problem? We really need to have the background field-01 for uploaded files.

@dakahn
Copy link
Contributor

dakahn commented Mar 11, 2019

No, sorry -- I meant that I see a background color for the uploaded files. I can't reproduce the bug.
2019-03-11 16_52_17-Window

@laurenmrice
Copy link
Member Author

Oh okay, weird. Because its happening in Firefox, Chrome and Safari for me

@dakahn dakahn mentioned this issue Mar 11, 2019
Merged
@dakahn
Copy link
Contributor

dakahn commented Mar 11, 2019

Addressed the height in this PR

As for the background color -- I cross checked in two different environment PC and macOS in both Firefox and Chrome. We'll wait to merge until someone else can check too. 🤷‍♂️

@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.84.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakahn dakahn

@laurenmrice laurenmrice

Labels
role: dev 🤖 version: 10 Issues pertaining to Carbon v10
Projects
None yet
Milestone
v10.0-rc1
Development

No branches or pull requests
3 participants
@carbon-bot @dakahn @laurenmrice