Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] incorrect motion with dropdown opening #2110

Closed
2 tasks
shixiedesign opened this issue Mar 15, 2019 · 8 comments
Closed
2 tasks

[Tabs] incorrect motion with dropdown opening #2110

shixiedesign opened this issue Mar 15, 2019 · 8 comments
Labels
component: tabs package: react carbon-components-react severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Milestone

Comments

@shixiedesign
Copy link
Contributor

Mobile dropdown variant:

  • The dropdown drawer opens without transition, but the shadow behind does! Closing animation appears fine.
  • Currently chevron and drawer animates sequentially. It should be simultaneous.
    Mar-15-2019 14-00-46
@asudoh
Copy link
Contributor

asudoh commented Mar 15, 2019

@shixiedesign Thank you for reporting! Double-checking - Does this happen only with mobile?

@shixiedesign
Copy link
Contributor Author

@asudoh Yep I believe so. No dropdown behavior at desktop size, so this is only with mobile.

@asudoh asudoh added this to the v10-update milestone Mar 18, 2019
@shinytoyrobots
Copy link
Contributor

@emyarod - I think this will be capture by dropdown work. Closing this issue but tagging for reference.

@emyarod
Copy link
Member

emyarod commented Apr 1, 2019

dropdown changes have already been merged in but does this issue still persist? @shixiedesign

@asudoh
Copy link
Contributor

asudoh commented Apr 1, 2019

Reopening as the dropdown UI in tab code is different from our dropdown code.

@asudoh asudoh reopened this Apr 1, 2019
@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@shixiedesign
Copy link
Contributor Author

Just checked. This is still an issue in our current tab component!

@stale stale bot removed the wontfix label May 2, 2019
@dakahn dakahn added package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity priority: high severity: 4 https://ibm.biz/carbon-severity and removed severity: 3 https://ibm.biz/carbon-severity labels May 13, 2019
@joshblack
Copy link
Contributor

Closing as I believe the dropdown will be going away with the tab updates in #4758 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs package: react carbon-components-react severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Development

No branches or pull requests

8 participants