Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carbon 10: List] Nested item issues #2282

Closed
elizabethsjudd opened this issue Apr 10, 2019 · 5 comments · Fixed by #2941
Closed

[Carbon 10: List] Nested item issues #2282

elizabethsjudd opened this issue Apr 10, 2019 · 5 comments · Fixed by #2941
Labels

Comments

@elizabethsjudd
Copy link
Contributor

Detailed description

There are multiple issues with the List component specifically with nested items

Describe in detail the issue you're having.

  1. Nesting an unordered list in an ordered list (or vise versa) does not display the correct list type
  2. Beyond the 2nd level of nested lists in ordered lists do not reset the counter
  3. (not sure if this is intended or not) when the list item wraps to a new line it is not indented to align with the text above it (it's aligned with the item marker)

Is this issue related to a specific component?

List

What did you expect to happen? What happened instead? What would you like to see changed?

  1. I should be able to mix and match list types when nesting lists and the user would understand what type of list it is
  2. The marker for nested lists would reset the counter/be denoted differently
  3. The text aligns with the text when it wraps instead of the marker

What browser are you working in?

Chrome

What version of the Carbon Design System are you using?

v10.0.0

What offering/product do you work on? Any pressing ship or release dates we should be aware of?

Watson Health Pattern & Asset Library (PAL)

Steps to reproduce the issue

  1. Use the HTML from the screen shot below
  2. view the issues

Additional information

Unordered list test
Screen Shot 2019-04-10 at 11 17 56 AM

Ordered list test
Screen Shot 2019-04-10 at 11 18 06 AM

@elizabethsjudd elizabethsjudd changed the title [Carbon X: List] Nested item issues [Carbon 10: List] Nested item issues Apr 10, 2019
@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@elizabethsjudd
Copy link
Contributor Author

elizabethsjudd commented May 6, 2019

Not stale. These issues are bugs not an enhancement since as users we can not properly nest lists.

@dakahn
Copy link
Contributor

dakahn commented May 8, 2019

@elizabethsjudd Seems to me this is both a bug report and a enhancement request. But sorry if I'm missing something you're saying here. I'll ping @carbon-design-system/design so they can comment on this use case and maybe offer a solution. 👍

@elizabethsjudd
Copy link
Contributor Author

@dakahn The main issues we are having is (1) if you nest a ul in an ol (or vise versa) they should show up as their correct list. Right now nested lists inherit the list style of the parent despite the semantic tag and (2) having more than 2 levels in a list does not reset the counter for the list style markers for ordered lists. Let me know if you need more clarification and we can set up a chat and I can point out the problems specifically within the screen shots.

@shixiedesign
Copy link
Contributor

shixiedesign commented May 9, 2019

At least these items are bug fixes:

  • resetting counter on nested ordered list
  • indent wrapped lines

Mixing list types is okay thing to do from a design standpoint. It's not in the original spec'ed behavior, but can be added to our functionalities if development can figure out how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants