Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT 1 - Form Item: DAP violations related to label #2459

Closed
snidersd opened this issue May 8, 2019 · 2 comments
Closed

AVT 1 - Form Item: DAP violations related to label #2459

snidersd opened this issue May 8, 2019 · 2 comments
Labels
package: react carbon-components-react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@snidersd
Copy link

snidersd commented May 8, 2019

Environment

macOS Mojave version 10.14.2
Chrome version 72.0.3626.96 (Official Build) (64-bit)

Detailed Description

Run DAP with Feb. 2019 ruleset on the Form Item Component
The following violations are reported:

Each form control must have an associated label
H44: Using label elements to associate text labels with form controls
ARIA16: Using aria-labelledby to provide a name for user interface controls
Provide descriptive text in label element
4.1.2 Name, Role, Value

This issue reopens #2188

To fix the issue fix the typo by replacing arialabel="Numeric input field with increment and decrement buttons" with aria-label="Numeric input field with increment and decrement buttons".
Remove the or include some text in the label. (See screenshot).
Screen Shot 2019-05-08 at 8 20 27 AM

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@joshblack joshblack added package: react carbon-components-react role: dev 🤖 labels May 9, 2019
@dakahn dakahn added priority: high severity: 3 https://ibm.biz/carbon-severity type: a11y ♿ labels May 14, 2019
@stale
Copy link

stale bot commented Jun 13, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 13, 2019
@snidersd
Copy link
Author

@dakahn I just retested and confirmed that there are no DAP violations.

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jun 13, 2019
@dakahn dakahn closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react role: dev 🤖 severity: 3 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Development

No branches or pull requests

3 participants