Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing descriptive text in label elements for toggle component. #2465

Closed
reeteshsingh93 opened this issue May 5, 2019 · 8 comments
Closed
Labels
package: react carbon-components-react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: inactive Will close if there's no further activity within a given time status: waiting for author's response 💬

Comments

@reeteshsingh93
Copy link

Environment

Operating system
MacOS Mojave

Browser

Chrome

Automated testing tool and ruleset

Assistive technology used to verify

Detailed description

What version of the Carbon Design System are you using?

"carbon-components": "9.57.0",
"carbon-components-react": "6.54.1",
"carbon-icons": "7.0.7",

What did you expect to happen?

What happened instead?

What WCAG 2.1 checkpoint does the issue violate?

Provide descriptive text in label elements

Steps to reproduce the issue

  1. Step one
  2. Step two
  3. Step three
  4. etc.

Please create a reduced test case in CodeSandbox
https://codesandbox.io/s/github/IBM/carbon-components-react/tree/master/examples/codesandbox

Additional information

  • Screenshots or code
    image

  • Notes
    I tried to add some text in label here...., that pass the test(DAP violation)

@dakahn
Copy link
Contributor

dakahn commented May 6, 2019

👋 Thanks for raising an issue. Please fill out the remainder of the issue template. Of special importance are A) specifying which DAP ruleset you're testing against and B) providing a reduced test case I can verify with.

@reeteshsingh93
Copy link
Author

DAP ruleset: IBM Accessibility February 2019

@dakahn
Copy link
Contributor

dakahn commented May 6, 2019

@reeteshsingh93 testing with that same ruleset against the Toggle component at v9.carboncomponents.com and I'm not getting that error.

If you could provide a test case where I can recreate what you're seeing that'd be cool 👍🏽

@carbon-bot carbon-bot transferred this issue from carbon-design-system/carbon-components-react May 9, 2019
@joshblack joshblack added package: react carbon-components-react role: dev 🤖 labels May 9, 2019
@stale
Copy link

stale bot commented Jun 9, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 9, 2019
@stale
Copy link

stale bot commented Jun 12, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Jun 12, 2019
@reeteshsingh93
Copy link
Author

Issue still persists...
image

@reeteshsingh93
Copy link
Author

reeteshsingh93 commented Jul 4, 2019

I created a sandbox and found descriptive text is not available in label element.
I have tested this manually don't have any option to perform accessibility test.

https://codesandbox.io/s/cc4k4

image

@emyarod
Copy link
Member

emyarod commented Jul 9, 2019

@reeteshsingh93 this appears to be resolved by carbon-design-system/carbon-components-react#1771 in v6.81.4. are you able to upgrade your dependencies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react role: dev 🤖 severity: 2 https://ibm.biz/carbon-severity status: inactive Will close if there's no further activity within a given time status: waiting for author's response 💬
Projects
None yet
Development

No branches or pull requests

4 participants