Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal discussion follow up #2922

Closed
2 of 8 tasks
aagonzales opened this issue Jun 4, 2019 · 16 comments
Closed
2 of 8 tasks

Modal discussion follow up #2922

aagonzales opened this issue Jun 4, 2019 · 16 comments

Comments

@aagonzales
Copy link
Member

aagonzales commented Jun 4, 2019

Conclusion from slack thread:
https://ibm-cloudplatform.slack.com/archives/C0M053VPT/p1559587807036800

Investigate/look-into:

  • Modals with multiple actions +2
    • with equal weight buttons (ie find and replace)
    • Progress modal variant (cancel, previous, next)
    • (cancel, previous, next) will by defacto become (cancel, previous, create/add system/finish etc)
  • Single button “acknowledgment” modal
    • Is passive modal still relevant with “acknowledgment” variant?
  • Modal consistency, in concern with introducing new button pattern behavior. (?)
  • Modal buttons dependent on modal size/width (%)
    • should there be a max modal size?
    • should there be a separate full page (or larger) version?
  • Smaller max-width option (define set modal sizes, not a %?)

Related to buttons:

  • Fixed button size with overflow content.
    • Buttons with a lot of content (internationalization) / no-truncation that have a fixed/constrained width.
  • Button pairing behavior, more than 2 (outside of modal context)
  • Update button style tab structure content.
@marceltrautmann
Copy link

marceltrautmann commented Jun 4, 2019

Adding some screen shots from the discussions related to some of the above (mostly progress modal);
image

image

It's worth mentioning, that with the progress modal variant, form elements are often par for the course, So longer modals are typical (sometimes wider)

@cragun47
Copy link

cragun47 commented Jun 4, 2019

Added detail request for Single acknowledgement modal: https://github.com/carbon-design-system/carbon/issues/2924

Single Modal Button

Video of use case where we would benefit from a single button "Continue" at the end of progress modal.
Progress.mov.zip

@elizabethsjudd
Copy link
Contributor

Here's WH's requirements around modal behaviors: requirements.txt

@aagonzales
Copy link
Member Author

Additional investigate smaller modal max-width, for "dialogs" or "message boxes"
https://ibm-cloudplatform.slack.com/archives/C0M053VPT/p1562701030157400

@stale
Copy link

stale bot commented Aug 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 8, 2019
@marceltrautmann
Copy link

keepalive-bot

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 8, 2019
@aagonzales
Copy link
Member Author

image

@amortiz
Copy link

amortiz commented Aug 21, 2019

Is there any discussion of providing a more traditional modal footer where buttons do not take the whole width of the dialog? It is quite different than the Carbon 9 modal or any other modals that i've seen from several applications / websites, wondering if there has been any user testing or reasoning behind going this way rather than the common approach.

@stale
Copy link

stale bot commented Sep 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 20, 2019
@marceltrautmann
Copy link

keepAlive[bot]

this one has garnered a lot of debate. potentially a good candidate to prioritize?

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 20, 2019
@aagonzales
Copy link
Member Author

Its top of our component enhancement list, the team just hasn't prioritized that project. Hopefully we get to it soon. Design's trying to get enhancements prioritized.

@creckling
Copy link

also see #3509

@aagonzales
Copy link
Member Author

Related: Nag Modal
#1478

@stale
Copy link

stale bot commented Dec 17, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Dec 17, 2019
@marceltrautmann
Copy link

keepAlive[bot]

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Dec 17, 2019
@aagonzales
Copy link
Member Author

Closing as modal have been updated in v10.8 and resolves many of this topic. Any items not covered my the modal updates can be opened as individual issues.

https://www.carbondesignsystem.com/components/modal/usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants