Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT- Dropdown list- Focused item is not visible when color is removed #3121

Closed
kcchen-tw opened this issue Jun 20, 2019 · 3 comments
Closed
Assignees

Comments

@kcchen-tw
Copy link

Title

When colour is removed, the focused item in dropdown list is not visible.

Environment

Browser
FF 67.03

Detailed description

What did you expect to happen?

  • A distinguishable visual focus indicator helps keyboard-only users locate the point of focus.

What happened instead?

  • The focus is not visible when you try to select any option on the menu.

Steps to reproduce the issue

  1. Step one: To remove color follow next steps:
    For Firefox®:
    • Select Tools >Options.
    • On the Language and Appearance section select Colors... button.
    • On the Colors window go to Override the colors specified by the page with your selections above: and open the menu and select Always, then press OK.
    • On the Advance button deselect the Allow pages to choose their own fonts, instead of your selections above checkbox.
    • Select OK to save changes.

  2. Step two:
    In url: http://react.carbondesignsystem.com/?path=/story/dropdown--default
    3

Please create a reduced test case in CodeSandbox

Additional information

It seems only the Vanilla JS has visible focus indicator:
Screenshot-2019-06-20-14:55:58

  • Notes
@emyarod
Copy link
Member

emyarod commented Jun 20, 2019

hi @kcchen-tw thanks for reporting this! yeah it seems the React dropdown changes the background color to indicate the selected item, opened #3124 to add focus outline to highlighted React dropdown items

@stale
Copy link

stale bot commented Jul 20, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 20, 2019
@stale
Copy link

stale bot commented Jul 23, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants