-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Combo box] all themes hover & select style wrong #3204
Comments
@aagonzales I believe that the styles for this are coming from the ListBox, which we use for MultiSelect and Dropdown, do you know if those components have the wrong colors too? |
in the latest pr i reviewed #4753 (comment) these seemed to be correct On the current live react link the colors are wrong. |
The deployed version may not be updated as of yet? Not sure how often we update it |
@laurenmrice thank you for looking into it! That PR should be included in the next minor release so if it's alright with you, we can close this issue? |
yeah i think this is fine to be closed ! i think its been resolved |
Noticed in vanilla, double checked in react:
All theme's hover & select styling on the dropdown is wrong.
Hovered option background be using color token
$hover-ui
Selected option background should be using color token
$selected-ui
Selected options border bottom should be using color token
$active-ui
The text was updated successfully, but these errors were encountered: