Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combo box] all themes hover & select style wrong #3204

Closed
shixiedesign opened this issue Jun 27, 2019 · 5 comments
Closed

[Combo box] all themes hover & select style wrong #3204

shixiedesign opened this issue Jun 27, 2019 · 5 comments
Assignees

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Jun 27, 2019

Noticed in vanilla, double checked in react:

All theme's hover & select styling on the dropdown is wrong.

Hovered option background be using color token $hover-ui
Selected option background should be using color token $selected-ui
Selected options border bottom should be using color token $active-ui

image

image

@shixiedesign shixiedesign changed the title [Combo box] all themes hover color wrong [Combo box] all themes hover&select style wrong Jun 27, 2019
@shixiedesign shixiedesign changed the title [Combo box] all themes hover&select style wrong [Combo box] all themes hover & select style wrong Jun 27, 2019
@abbeyhrt abbeyhrt self-assigned this Jan 15, 2020
@abbeyhrt
Copy link
Contributor

@aagonzales I believe that the styles for this are coming from the ListBox, which we use for MultiSelect and Dropdown, do you know if those components have the wrong colors too?

@laurenmrice
Copy link
Member

in the latest pr i reviewed #4753 (comment) these seemed to be correct

On the current live react link the colors are wrong.

@tw15egan
Copy link
Collaborator

The deployed version may not be updated as of yet? Not sure how often we update it

@abbeyhrt
Copy link
Contributor

@laurenmrice thank you for looking into it! That PR should be included in the next minor release so if it's alright with you, we can close this issue?

@laurenmrice
Copy link
Member

yeah i think this is fine to be closed ! i think its been resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants