Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormItem]: FormItem story issues #4573

Closed
vpicone opened this issue Nov 5, 2019 · 1 comment · Fixed by #5379
Closed

[FormItem]: FormItem story issues #4573

vpicone opened this issue Nov 5, 2019 · 1 comment · Fixed by #5379
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities type: bug 🐛 type: docs 📖 type: enhancement 💡

Comments

@vpicone
Copy link
Contributor

vpicone commented Nov 5, 2019

The FormItem story incorrectly uses the component to wrap a NumberInput which already has a FormItem wrapper. The 'documentation' is also non-existent and doesn't explain how the component is actually meant to be used.
@vpicone
Copy link
Contributor Author

vpicone commented Nov 5, 2019

We should just remove the story unless we intend on implementing #2549 and forcing devs to wrap all of our form inputs with this wrapper (not sure this is a great idea)

@vpicone vpicone added good first issue 👋 Used by GitHub to elevate contribution opportunities type: docs 📖 labels Nov 5, 2019
@tw15egan tw15egan mentioned this issue Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue 👋 Used by GitHub to elevate contribution opportunities type: bug 🐛 type: docs 📖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(FormItem): remove FormItem story tw15egan/carbon
2 participants
@mattrosno @vpicone