Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notification]: add info icon to info inline and toast notifications #5190

Closed
2 tasks
jeanservaas opened this issue Jan 27, 2020 · 3 comments · Fixed by #5203
Closed
2 tasks

[Notification]: add info icon to info inline and toast notifications #5190

jeanservaas opened this issue Jan 27, 2020 · 3 comments · Fixed by #5203
Assignees
@tw15egan
Labels
component: notification package: components carbon-components package: sketch @carbon/sketch role: dev 🤖 type: enhancement 💡

Comments

@jeanservaas
Copy link
Collaborator

[Notification]: add info icon to info inline and toast notifications

  • update component package

  • update kit

No reason not to have icons on all four notification types, it adds consistency and visual interest to the info notification.

The icon color will take the $support-04 token (it will be Blue 70 in the light themes and Blue 50 in the dark themes)

Toast notification: all structural specs and tokens match the other 3 notifcations (both inline and toast) that have icons. Nothing new here, but provided visuals for reference.

image.png

Inline notification:

image.png
@jeanservaas
Copy link
Collaborator Author

related to
#5055

@asudoh
Copy link
Contributor

asudoh commented Jan 27, 2020

Hi @jeanservaas thank you for writing this up! Is this dev-ready?

@tw15egan tw15egan self-assigned this Jan 28, 2020
@laurenmrice
Copy link
Member

yes its dev ready ^

@laurenmrice laurenmrice mentioned this issue Jan 28, 2020
Closed
5 tasks
@tw15egan tw15egan mentioned this issue Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tw15egan tw15egan

Labels
component: notification package: components carbon-components package: sketch @carbon/sketch role: dev 🤖 type: enhancement 💡
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(notification): add info icon to notification tw15egan/carbon
4 participants
@asudoh @tw15egan @jeanservaas @laurenmrice